Anton Protopopov 1a9e80f757 bpf: fix a memory leak in the LRU and LRU_PERCPU hash maps ... commit b34ffb0c6d23583830f9327864b9c1f486003305 upstream. The LRU and LRU_PERCPU maps allocate a new element on update before locking the target hash table bucket. Right after that the maps try to lock the bucket. If this fails, then maps return -EBUSY to the caller without releasing the allocated element. This makes the element untracked: it doesn't belong to either of free lists, and it doesn't belong to the hash table, so can't be re-used; this eventually leads to the permanent -ENOMEM on LRU map updates, which is unexpected. Fix this by returning the element to the local free list if bucket locking fails. Fixes: 20b6cc34ea ("bpf: Avoid hashtab deadlock with map_locked") Signed-off-by: Anton Protopopov <aspsk@isovalent.com> Link: https://lore.kernel.org/r/20230522154558.2166815-1-aspsk@isovalent.com Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-05-30 14:03:21 +01:00
..
preload	bpf: iterators: Build and use lightweight bootstrap version of bpftool	2022-07-15 12:01:30 -07:00
arraymap.c	bpf: Support kptrs in percpu arraymap	2022-09-07 11:46:08 -07:00
bloom_filter.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
bpf_inode_storage.c	bpf: Compute map_btf_id during build time	2022-04-26 11:35:21 -07:00
bpf_iter.c	bpf: Initialize the bpf_run_ctx in bpf_iter_run_prog()	2022-08-18 17:06:13 -07:00
bpf_local_storage.c	bpf: Annotate data races in bpf_local_storage	2023-05-24 17:32:36 +01:00
bpf_lru_list.c	bpf_lru_list: Read double-checked variable once without lock	2021-02-10 15:54:26 -08:00
bpf_lru_list.h	printk: stop including cache.h from printk.h	2022-05-13 07:20:07 -07:00
bpf_lsm.c	bpf: Fix the kernel crash caused by bpf_setsockopt().	2023-02-09 11:28:02 +01:00
bpf_struct_ops_types.h	bpf: Add dummy BPF STRUCT_OPS for test purpose	2021-11-01 14:10:00 -07:00
bpf_struct_ops.c	bpf: Remove is_valid_bpf_tramp_flags()	2022-07-11 21:04:58 +02:00
bpf_task_storage.c	bpf: Use this_cpu_{inc|dec|inc_return} for bpf_task_storage_busy	2022-09-01 12:16:12 -07:00
btf.c	bpf: Fix race between btf_put and btf_idr walk.	2023-05-11 23:03:26 +09:00
cgroup_iter.c	bpf: Pin the start cgroup in cgroup_iter_seq_init()	2022-12-31 13:32:13 +01:00
cgroup.c	bpf: Don't EFAULT for getsockopt with optval=NULL	2023-05-11 23:03:26 +09:00
core.c	bpf: Adjust insufficient default bpf_jit_limit	2023-03-30 12:49:08 +02:00
cpumap.c	bpf: Use bpf_map_area_alloc consistently on bpf map creation	2022-08-10 11:50:43 -07:00
devmap.c	bpf: Use bpf_map_area_alloc consistently on bpf map creation	2022-08-10 11:50:43 -07:00
disasm.c	bpf: Relicense disassembler as GPL-2.0-only OR BSD-2-Clause	2021-09-02 14:49:23 +02:00
disasm.h	bpf: Relicense disassembler as GPL-2.0-only OR BSD-2-Clause	2021-09-02 14:49:23 +02:00
dispatcher.c	bpf: Add explicit cast to 'void *' for __BPF_DISPATCHER_UPDATE()	2022-11-07 16:07:35 -08:00
hashtab.c	bpf: fix a memory leak in the LRU and LRU_PERCPU hash maps	2023-05-30 14:03:21 +01:00
helpers.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-10-03 17:44:18 -07:00
inode.c	bpf: Convert bpf_preload.ko to use light skeleton.	2022-02-10 23:31:51 +01:00
Kconfig	rcu: Make the TASKS_RCU Kconfig option be selected	2022-04-20 16:52:58 -07:00
link_iter.c	bpf: Add bpf_link iterator	2022-05-10 11:20:45 -07:00
local_storage.c	bpf: Use bpf_map_area_alloc consistently on bpf map creation	2022-08-10 11:50:43 -07:00
lpm_trie.c	bpf: Use bpf_map_area_alloc consistently on bpf map creation	2022-08-10 11:50:43 -07:00
Makefile	bpf: Introduce any context BPF specific memory allocator.	2022-09-05 15:33:05 +02:00
map_in_map.c	bpf: Allow storing unreferenced kptr in map	2022-04-25 17:31:35 -07:00
map_in_map.h	bpf: Add map_meta_equal map ops	2020-08-28 15:41:30 +02:00
map_iter.c	bpf: Introduce MEM_RDONLY flag	2021-12-18 13:27:41 -08:00
memalloc.c	bpf: Zeroing allocated object from slab in bpf memory allocator	2023-03-10 09:33:06 +01:00
mmap_unlock_work.h	bpf: Introduce helper bpf_find_vma	2021-11-07 11:54:51 -08:00
net_namespace.c	net: Add includes masked by netdevice.h including uapi/bpf.h	2021-12-29 20:03:05 -08:00
offload.c	bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD and PERF_BPF_EVENT_PROG_UNLOAD	2023-01-24 07:24:37 +01:00
percpu_freelist.c	bpf: Initialize same number of free nodes for each pcpu_freelist	2022-11-11 12:05:14 -08:00
percpu_freelist.h	bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI	2020-10-06 00:04:11 +02:00
prog_iter.c	bpf: Refactor bpf_iter_reg to have separate seq_info member	2020-07-25 20:16:32 -07:00
queue_stack_maps.c	bpf: Remove unneeded memset in queue_stack_map creation	2022-08-10 11:48:22 -07:00
reuseport_array.c	net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()	2022-08-17 16:42:59 -07:00
ringbuf.c	bpf: Add bpf_user_ringbuf_drain() helper	2022-09-21 16:24:58 -07:00
stackmap.c	perf/bpf: Always use perf callchains if exist	2022-09-13 15:03:22 +02:00
syscall.c	bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD and PERF_BPF_EVENT_PROG_UNLOAD	2023-01-24 07:24:37 +01:00
sysfs_btf.c	bpf: Load and verify kernel module BTFs	2020-11-10 15:25:53 -08:00
task_iter.c	bpf: keep a reference to the mm, in case the task is dead.	2023-01-24 07:24:31 +01:00
tnum.c	bpf, tnums: Provably sound, faster, and more precise algorithm for tnum_mul	2021-06-01 13:34:15 +02:00
trampoline.c	bpf: Fix panic due to wrong pageattr of im->image	2023-01-12 12:02:45 +01:00
verifier.c	bpf: Fix mask generation for 32-bit narrow loads of 64-bit fields	2023-05-30 14:03:21 +01:00