commit 7663d522099ecc464512164e660bc771b2ff7b64 upstream.
It's currently possible to create an altname conflicting
with an altname or real name of another device by creating
it in another netns and moving it over:
[ ~]$ ip link add dev eth0 type dummy
[ ~]$ ip netns add test
[ ~]$ ip -netns test link add dev ethX netns test type dummy
[ ~]$ ip -netns test link property add dev ethX altname eth0
[ ~]$ ip -netns test link set dev ethX netns 1
[ ~]$ ip link
...
3: eth0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/ether 02:40:88:62:ec:b8 brd ff:ff:ff:ff:ff:ff
...
5: ethX: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/ether 26:b7:28:78:38:0f brd ff:ff:ff:ff:ff:ff
altname eth0
Create a macro for walking the altnames, this hopefully makes
it clearer that the list we walk contains only altnames.
Which is otherwise not entirely intuitive.
Fixes: 36fbf1e52b
("net: rtnetlink: add linkprop commands to add and delete alternative ifnames")
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
116 lines
3.4 KiB
C
116 lines
3.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
#ifndef _NET_CORE_DEV_H
|
|
#define _NET_CORE_DEV_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct net;
|
|
struct net_device;
|
|
struct netdev_bpf;
|
|
struct netdev_phys_item_id;
|
|
struct netlink_ext_ack;
|
|
|
|
/* Random bits of netdevice that don't need to be exposed */
|
|
#define FLOW_LIMIT_HISTORY (1 << 7) /* must be ^2 and !overflow buckets */
|
|
struct sd_flow_limit {
|
|
u64 count;
|
|
unsigned int num_buckets;
|
|
unsigned int history_head;
|
|
u16 history[FLOW_LIMIT_HISTORY];
|
|
u8 buckets[];
|
|
};
|
|
|
|
extern int netdev_flow_limit_table_len;
|
|
|
|
#ifdef CONFIG_PROC_FS
|
|
int __init dev_proc_init(void);
|
|
#else
|
|
#define dev_proc_init() 0
|
|
#endif
|
|
|
|
void linkwatch_init_dev(struct net_device *dev);
|
|
void linkwatch_forget_dev(struct net_device *dev);
|
|
void linkwatch_run_queue(void);
|
|
|
|
void dev_addr_flush(struct net_device *dev);
|
|
int dev_addr_init(struct net_device *dev);
|
|
void dev_addr_check(struct net_device *dev);
|
|
|
|
/* sysctls not referred to from outside net/core/ */
|
|
extern int netdev_budget;
|
|
extern unsigned int netdev_budget_usecs;
|
|
extern unsigned int sysctl_skb_defer_max;
|
|
extern int netdev_tstamp_prequeue;
|
|
extern int netdev_unregister_timeout_secs;
|
|
extern int weight_p;
|
|
extern int dev_weight_rx_bias;
|
|
extern int dev_weight_tx_bias;
|
|
|
|
/* rtnl helpers */
|
|
extern struct list_head net_todo_list;
|
|
void netdev_run_todo(void);
|
|
|
|
/* netdev management, shared between various uAPI entry points */
|
|
struct netdev_name_node {
|
|
struct hlist_node hlist;
|
|
struct list_head list;
|
|
struct net_device *dev;
|
|
const char *name;
|
|
};
|
|
|
|
int netdev_get_name(struct net *net, char *name, int ifindex);
|
|
int dev_change_name(struct net_device *dev, const char *newname);
|
|
|
|
#define netdev_for_each_altname(dev, namenode) \
|
|
list_for_each_entry((namenode), &(dev)->name_node->list, list)
|
|
|
|
int netdev_name_node_alt_create(struct net_device *dev, const char *name);
|
|
int netdev_name_node_alt_destroy(struct net_device *dev, const char *name);
|
|
|
|
int dev_validate_mtu(struct net_device *dev, int mtu,
|
|
struct netlink_ext_ack *extack);
|
|
int dev_set_mtu_ext(struct net_device *dev, int mtu,
|
|
struct netlink_ext_ack *extack);
|
|
|
|
int dev_get_phys_port_id(struct net_device *dev,
|
|
struct netdev_phys_item_id *ppid);
|
|
int dev_get_phys_port_name(struct net_device *dev,
|
|
char *name, size_t len);
|
|
|
|
int dev_change_proto_down(struct net_device *dev, bool proto_down);
|
|
void dev_change_proto_down_reason(struct net_device *dev, unsigned long mask,
|
|
u32 value);
|
|
|
|
typedef int (*bpf_op_t)(struct net_device *dev, struct netdev_bpf *bpf);
|
|
int dev_change_xdp_fd(struct net_device *dev, struct netlink_ext_ack *extack,
|
|
int fd, int expected_fd, u32 flags);
|
|
|
|
int dev_change_tx_queue_len(struct net_device *dev, unsigned long new_len);
|
|
void dev_set_group(struct net_device *dev, int new_group);
|
|
int dev_change_carrier(struct net_device *dev, bool new_carrier);
|
|
|
|
void __dev_set_rx_mode(struct net_device *dev);
|
|
|
|
static inline void netif_set_gso_max_size(struct net_device *dev,
|
|
unsigned int size)
|
|
{
|
|
/* dev->gso_max_size is read locklessly from sk_setup_caps() */
|
|
WRITE_ONCE(dev->gso_max_size, size);
|
|
}
|
|
|
|
static inline void netif_set_gso_max_segs(struct net_device *dev,
|
|
unsigned int segs)
|
|
{
|
|
/* dev->gso_max_segs is read locklessly from sk_setup_caps() */
|
|
WRITE_ONCE(dev->gso_max_segs, segs);
|
|
}
|
|
|
|
static inline void netif_set_gro_max_size(struct net_device *dev,
|
|
unsigned int size)
|
|
{
|
|
/* This pairs with the READ_ONCE() in skb_gro_receive() */
|
|
WRITE_ONCE(dev->gro_max_size, size);
|
|
}
|
|
|
|
#endif
|