FUJITA Tomonori 3d164fb09b
[SCSI] ch: fix ch_remove oops ...
The following commit causes ch_remove oops:
commit 24b42566c3fcbb5a9011d1446783d0f5844ccd45
Author: Greg Kroah-Hartman <gregkh@suse.de>
Date: Fri May 16 17:55:12 2008 -0700
SCSI: fix race in device_create
There is a race from when a device is created with device_create() and
then the drvdata is set with a call to dev_set_drvdata() in which a
sysfs file could be open, yet the drvdata will be NULL, causing all
sorts of bad things to happen.
This patch fixes the problem by using the new function,
device_create_drvdata(). It fixes the problem in all of the scsi
drivers that need it.
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Doug Gilbert <dgilbert@interlog.com>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
The problem is ch_probe stores ch's private data at a wrong place.
We need to store it at scsi_device->sdev_gendev but the above patch
stores it at device struct that device_create_drvdata returns. So we
hit an oops when ch_remove accesses
scsi_device->sdev_gendev->driver_data, which is NULL.
Actually, there wasn't a race because ch doesn't create sysfs files
with device struct that device_create returns. This patch puts back
dev_set_drvdata() to set ch's private data properly.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2008-07-26 15:17:47 -04:00
2008-07-15 18:58:04 -07:00
2008-04-28 17:31:13 -07:00
2006-06-30 19:25:36 +02:00
2008-07-10 14:26:15 +01:00
2008-04-19 19:10:33 -07:00
2008-07-03 14:25:57 +01:00
2008-07-26 15:14:54 -04:00
2008-06-15 11:12:20 -05:00
2008-07-26 15:14:59 -04:00
2008-04-18 11:25:31 -07:00
2008-07-12 08:22:29 -05:00
2008-06-20 14:05:58 -06:00
2008-04-19 19:10:33 -07:00
2008-07-26 15:14:47 -04:00
2008-07-26 15:14:49 -04:00
2008-07-26 15:14:56 -04:00
2008-01-11 18:22:30 -06:00
2008-07-26 15:15:00 -04:00
2008-07-26 15:15:00 -04:00
2008-06-20 14:05:53 -06:00
2007-01-06 09:18:00 -06:00
2008-05-02 10:18:22 -05:00
2007-06-17 16:15:56 -05:00
2008-07-15 14:30:56 -07:00
2007-06-17 16:09:29 -05:00
2008-04-07 12:19:07 -05:00
2006-09-12 17:12:31 -05:00
2008-04-07 12:19:01 -05:00
2006-09-12 17:12:31 -05:00
2007-10-12 14:41:00 -04:00
2008-03-07 10:05:43 -06:00
2008-05-23 08:11:07 -07:00
2007-08-04 09:11:06 -05:00
2008-04-27 12:19:55 -05:00
2005-11-09 15:44:09 -05:00
2008-01-30 13:14:02 -06:00
2008-02-06 10:41:01 -08:00
2006-10-05 15:10:12 +01:00
2008-01-11 18:28:57 -06:00
2007-11-25 12:19:26 +02:00
2007-05-04 17:59:05 -07:00
2008-05-23 08:11:07 -07:00
2005-09-15 08:59:36 -05:00
2008-04-07 12:15:44 -05:00
2008-04-07 12:15:44 -05:00
2007-10-12 14:41:00 -04:00
2008-07-26 15:17:47 -04:00
2008-05-02 11:33:25 -05:00
2008-04-07 12:15:40 -05:00
2006-09-26 11:35:32 -07:00
2008-07-21 21:54:44 -07:00
2008-05-08 10:46:56 -07:00
2007-11-25 12:19:26 +02:00
2005-11-09 15:44:09 -05:00
2007-03-20 11:27:03 -05:00
2008-04-07 12:15:40 -05:00
2008-04-25 09:52:30 -05:00
2008-07-15 18:58:04 -07:00
2008-06-25 12:36:13 -05:00
2008-01-11 18:22:35 -06:00
2008-04-28 17:31:13 -07:00
2008-04-27 12:19:55 -05:00
2007-11-25 12:19:26 +02:00
2006-06-30 19:25:36 +02:00
2008-02-18 09:02:25 -06:00
2007-10-12 14:55:46 -04:00
2008-06-20 14:05:49 -06:00
2008-04-07 12:15:36 -05:00
2008-04-07 12:19:07 -05:00
2006-09-12 17:12:31 -05:00
2008-07-21 21:54:52 -07:00
2008-05-23 08:11:07 -07:00
2008-01-11 18:28:06 -06:00
2008-01-30 13:14:02 -06:00
2008-07-24 22:53:35 +02:00
2008-01-11 18:22:41 -06:00
2006-10-04 03:38:54 -04:00
2008-01-11 18:22:36 -06:00
2005-11-09 15:44:09 -05:00
2008-05-02 10:18:22 -05:00
2007-05-22 11:08:56 -05:00
2008-07-11 13:45:48 -05:00
2007-05-08 11:54:40 -05:00
2008-04-07 12:19:11 -05:00
2008-01-11 18:27:59 -06:00
2008-07-12 08:22:29 -05:00
2008-07-12 08:22:20 -05:00
2008-04-27 12:33:04 -05:00
2008-07-26 15:14:56 -04:00
2007-07-19 10:04:50 -07:00
2008-07-12 08:22:29 -05:00
2008-01-30 13:03:40 -06:00
2008-01-30 13:14:02 -06:00
2008-05-21 16:56:00 -07:00
2008-04-07 12:15:40 -05:00
2008-07-26 15:14:56 -04:00
2008-06-20 14:05:53 -06:00
2007-05-08 11:15:08 -05:00
2008-06-05 09:23:44 -05:00
2007-10-12 14:41:00 -04:00
2008-04-07 12:19:07 -05:00
2006-09-12 17:12:31 -05:00
2008-05-01 08:04:03 -07:00
2008-05-01 08:04:02 -07:00
2007-10-12 14:51:18 -04:00
2008-01-30 13:14:02 -06:00
2008-01-23 13:44:31 -06:00
2007-10-12 14:55:07 -04:00
2007-10-12 14:41:00 -04:00
2007-07-19 10:04:50 -07:00
2008-01-30 13:14:02 -06:00
2007-10-19 11:53:42 -07:00
2008-07-14 15:29:34 -06:00
2007-10-12 14:50:55 -04:00
2007-11-25 12:19:26 +02:00
2005-11-09 15:44:09 -05:00
2008-01-11 18:22:41 -06:00
2006-10-04 03:38:54 -04:00
2008-04-07 12:19:02 -05:00
2008-05-23 08:11:07 -07:00
2007-10-23 12:35:35 -04:00
2007-10-22 21:19:53 +02:00
2006-10-25 15:11:55 -07:00
2008-01-30 13:14:02 -06:00
2006-10-17 19:28:51 -07:00
2008-02-23 09:07:32 -06:00
2007-10-12 14:52:38 -04:00
2008-04-19 19:10:33 -07:00
2008-07-12 08:22:30 -05:00
2008-04-29 08:06:19 -07:00
2008-07-26 15:14:56 -04:00
2008-01-11 18:22:50 -06:00
2007-07-14 19:28:10 -05:00
2008-07-26 15:14:59 -04:00
2006-06-30 19:25:36 +02:00
2008-01-28 15:08:07 -08:00
2008-07-26 15:14:55 -04:00
2008-04-29 08:06:21 -07:00
2008-04-19 19:10:33 -07:00
2008-07-26 15:14:56 -04:00
2007-07-18 11:16:32 -05:00
2008-07-26 15:14:54 -04:00
2008-07-02 15:06:25 -06:00
2008-05-02 10:18:22 -05:00
2007-10-12 14:37:50 -04:00
2006-05-20 00:39:08 -04:00
2007-10-12 14:46:58 -04:00
2008-07-21 21:54:52 -07:00
2008-07-21 21:54:52 -07:00
2008-04-29 14:48:33 +02:00
2008-04-27 12:19:55 -05:00
2007-10-12 14:38:09 -04:00
2008-04-19 19:10:33 -07:00
2006-06-10 16:24:40 -05:00
2006-10-11 13:44:25 -05:00
2008-07-26 15:14:55 -04:00
2006-08-19 13:39:11 -07:00
2008-01-11 18:22:40 -06:00
2008-07-26 15:14:56 -04:00
2008-07-26 15:14:56 -04:00
2008-07-26 15:14:56 -04:00
2008-06-24 12:02:27 -05:00
2008-07-15 18:58:04 -07:00
2008-04-27 12:33:04 -05:00
2007-07-22 11:36:49 -07:00
2008-04-27 12:33:04 -05:00
2008-02-07 18:02:44 -06:00
2006-12-13 09:05:58 -08:00
2008-07-04 09:52:14 +02:00
2008-02-07 18:02:44 -06:00
2008-04-07 12:15:39 -05:00
2008-07-26 15:14:47 -04:00
2008-04-07 12:15:39 -05:00
2008-07-26 15:14:49 -04:00
2008-01-11 18:28:57 -06:00
2008-04-16 09:28:11 -05:00
2007-11-25 12:19:26 +02:00
2006-12-09 09:41:18 -08:00
2008-04-27 12:33:04 -05:00
2008-07-24 10:47:21 -07:00
2008-02-12 15:24:58 -06:00
2005-11-09 15:44:09 -05:00
2007-11-25 12:19:26 +02:00
2006-11-15 16:43:50 -06:00
2008-01-23 11:29:27 -06:00
2007-07-14 18:56:33 -05:00
2008-05-02 13:18:06 -05:00
2008-04-28 17:31:13 -07:00
2006-09-07 12:39:34 -05:00
2008-04-07 12:19:01 -05:00
2007-10-19 23:22:55 +02:00
2008-01-30 13:14:02 -06:00
2006-07-02 13:58:53 -07:00
2007-11-29 09:24:52 -08:00
3d164fb09b