Tejun Heo
1be0c25da5
workqueue: don't perform NUMA-aware allocations on offline nodes in wq_numa_init()
wq_numa_init() builds per-node cpumasks which are later used to make
unbound workqueues NUMA-aware. The cpumasks are allocated using
alloc_cpumask_var_node() for all possible nodes. Unfortunately, on
machines with off-line nodes, this leads to NUMA-aware allocations on
existing bug offline nodes, which in turn triggers BUG in the memory
allocation code.
Fix it by using NUMA_NO_NODE for cpumask allocations for offline
nodes.
kernel BUG at include/linux/gfp.h:323!
invalid opcode: 0000 [#1] SMP
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.9.0+ #1
Hardware name: ProLiant BL465c G7, BIOS A19 12/10/2011
task: ffff880234608000 ti: ffff880234602000 task.ti: ffff880234602000
RIP: 0010:[<ffffffff8117495d>] [<ffffffff8117495d>] new_slab+0x2ad/0x340
RSP: 0000:ffff880234603bf8 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff880237404b40 RCX: 00000000000000d0
RDX: 0000000000000001 RSI: 0000000000000003 RDI: 00000000002052d0
RBP: ffff880234603c28 R08: 0000000000000000 R09: 0000000000000001
R10: 0000000000000001 R11: ffffffff812e3aa8 R12: 0000000000000001
R13: ffff8802378161c0 R14: 0000000000030027 R15: 00000000000040d0
FS: 0000000000000000(0000) GS:ffff880237800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: ffff88043fdff000 CR3: 00000000018d5000 CR4: 00000000000007f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Stack:
ffff880234603c28 0000000000000001 00000000000000d0 ffff8802378161c0
ffff880237404b40 ffff880237404b40 ffff880234603d28 ffffffff815edba1
ffff880237816140 0000000000000000 ffff88023740e1c0
Call Trace:
[<ffffffff815edba1>] __slab_alloc+0x330/0x4f2
[<ffffffff81174b25>] kmem_cache_alloc_node_trace+0xa5/0x200
[<ffffffff812e3aa8>] alloc_cpumask_var_node+0x28/0x90
[<ffffffff81a0bdb3>] wq_numa_init+0x10d/0x1be
[<ffffffff81a0bec8>] init_workqueues+0x64/0x341
[<ffffffff810002ea>] do_one_initcall+0xea/0x1a0
[<ffffffff819f1f31>] kernel_init_freeable+0xb7/0x1ec
[<ffffffff815d50de>] kernel_init+0xe/0xf0
[<ffffffff815ff89c>] ret_from_fork+0x7c/0xb0
Code: 45 84 ac 00 00 00 f0 41 80 4d 00 40 e9 f6 fe ff ff 66 0f 1f 84 00 00 00 00 00 e8 eb 4b ff ff 49 89 c5 e9 05 fe ff ff <0f> 0b 4c 8b 73 38 44 89 ff 81 cf 00 00 20 00 4c 89 f6 48 c1 ee
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-and-Tested-by: Lingzhu Xiang <lxiang@redhat.com>
2013-05-15 14:24:24 -07:00
..
2013-04-30 08:15:40 -07:00
2013-04-30 17:04:10 -07:00
2013-05-05 13:23:27 -07:00
2013-01-11 11:39:33 -08:00
2013-05-06 11:37:43 +10:00
2013-05-02 19:40:34 -07:00
2013-05-05 13:23:27 -07:00
2013-05-05 13:23:27 -07:00
2013-05-08 11:51:05 -07:00
2013-04-22 07:09:06 -07:00
2013-05-04 14:57:58 -04:00
2013-03-12 13:59:14 -07:00
2013-04-29 15:54:26 -07:00
2013-01-11 14:54:55 -08:00
2013-05-01 14:08:52 -07:00
2013-04-29 15:54:26 -07:00
2013-04-29 15:54:26 -07:00
2013-04-29 15:54:26 -07:00
2013-04-14 10:06:31 -07:00
2012-11-19 08:13:38 -08:00
2013-05-01 17:51:54 -07:00
2013-05-01 07:21:43 -07:00
2013-05-01 17:29:18 -04:00
2013-02-19 18:19:48 -08:00
2012-05-31 17:49:27 -07:00
2013-02-19 19:04:55 -08:00
2013-05-01 17:51:54 -07:00
2011-11-06 19:44:47 -08:00
2012-12-18 10:55:28 -08:00
2013-01-27 19:23:31 +01:00
2012-03-28 18:30:03 +01:00
2013-05-01 17:51:54 -07:00
2013-04-15 13:25:16 +02:00
2013-05-08 11:51:05 -07:00
2012-10-26 14:27:49 -07:00
2013-02-23 18:50:11 -08:00
2013-03-12 20:42:10 -07:00
2012-05-03 03:29:33 -07:00
2013-05-05 13:23:27 -07:00
2012-04-25 12:39:25 +02:00
2013-02-05 00:48:46 +01:00
2012-04-10 11:00:30 +02:00
2012-08-06 19:00:35 +03:00
2013-04-15 15:17:26 +09:30
2012-12-20 17:40:19 -08:00
2012-09-13 17:56:13 +02:00
2012-03-23 13:18:57 +01:00
2013-04-30 17:04:07 -07:00
2013-04-30 17:04:06 -07:00
2013-04-18 08:58:38 -07:00
2012-12-11 18:10:49 -08:00
2013-04-30 17:04:02 -07:00
2011-10-31 09:20:12 -04:00
2012-05-29 23:28:41 -04:00
2012-10-24 12:39:09 +02:00
2013-05-08 11:51:05 -07:00
2013-05-05 10:58:06 -07:00
2013-03-15 15:09:43 +10:30
2012-12-20 17:40:21 -08:00
2012-12-05 11:27:24 +10:30
2012-10-19 17:30:40 -07:00
2013-04-17 13:23:02 +09:30
2011-10-31 09:20:12 -04:00
2013-04-19 09:33:36 +02:00
2011-10-31 09:20:12 -04:00
2013-05-01 17:29:39 -04:00
2012-12-06 17:16:23 +08:00
2013-04-30 17:04:02 -07:00
2013-03-18 11:40:21 +00:00
2013-05-01 17:51:54 -07:00
2013-05-01 17:51:54 -07:00
2013-04-22 19:59:25 +02:00
2013-04-18 12:51:19 +02:00
2013-05-07 20:16:25 -07:00
2013-05-01 17:29:18 -04:00
2013-05-07 20:16:25 -07:00
2013-04-30 17:04:01 -07:00
2013-01-28 22:06:21 -08:00
2013-01-28 22:25:21 -08:00
2013-01-28 22:06:21 -08:00
2013-01-28 22:25:21 -08:00
2013-02-04 12:18:20 -08:00
2013-05-05 13:23:27 -07:00
2013-05-05 00:16:35 -04:00
2013-05-02 17:54:19 +02:00
2013-05-02 17:54:19 +02:00
2013-05-08 10:13:35 -07:00
2012-12-18 15:02:12 -08:00
2013-04-29 15:54:40 -07:00
2013-02-07 20:51:08 +01:00
2013-04-10 14:48:37 +02:00
2013-02-07 20:51:08 +01:00
2013-03-23 15:53:52 -07:00
2013-03-26 11:07:19 +11:00
2013-04-30 17:04:08 -07:00
2013-05-01 14:08:52 -07:00
2013-04-30 17:04:03 -07:00
2013-04-12 14:18:43 +02:00
2012-08-13 17:01:07 +02:00
2013-05-05 13:23:27 -07:00
2012-03-23 13:18:57 +01:00
2013-02-07 15:19:36 -08:00
2011-10-31 09:20:12 -04:00
2013-02-26 22:25:17 +01:00
2013-05-09 13:46:38 -04:00
2013-05-01 07:21:43 -07:00
2013-05-09 14:53:20 -04:00
2013-04-29 15:54:36 -07:00
2012-09-13 16:47:34 +02:00
2012-10-06 03:05:31 +09:00
2013-04-29 18:28:42 -07:00
2013-03-15 16:50:20 -07:00
2013-02-16 23:17:25 +01:00
2013-05-05 13:23:27 -07:00
2013-04-29 13:55:38 -07:00
2013-01-27 19:23:31 +01:00
2013-03-03 22:58:33 -05:00
2011-10-31 09:20:12 -04:00
2013-05-01 17:51:54 -07:00
2013-02-27 19:10:24 -08:00
2013-05-01 17:51:54 -07:00
2013-02-27 19:10:22 -08:00
2013-05-01 17:29:39 -04:00
2012-12-06 10:39:54 +01:00
2013-03-14 08:24:05 +01:00
2013-04-30 17:04:02 -07:00
2013-05-15 14:24:24 -07:00