Eric Biggers
49686cbbb3
NFS: reject request for id_legacy key without auxdata
...
nfs_idmap_legacy_upcall() is supposed to be called with 'aux' pointing
to a 'struct idmap', via the call to request_key_with_auxdata() in
nfs_idmap_request_key().
However it can also be reached via the request_key() system call in
which case 'aux' will be NULL, causing a NULL pointer dereference in
nfs_idmap_prepare_pipe_upcall(), assuming that the key description is
valid enough to get that far.
Fix this by making nfs_idmap_legacy_upcall() negate the key if no
auxdata is provided.
As usual, this bug was found by syzkaller. A simple reproducer using
the command-line keyctl program is:
keyctl request2 id_legacy uid:0 '' @s
Fixes: 57e62324e469 ("NFS: Store the legacy idmapper result in the keyring")
Reported-by: syzbot+5dfdbcf7b3eb5912abbb@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org> # v3.4+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Trond Myklebust <trondmy@gmail.com>
2018-01-22 10:05:11 -05:00
..
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2018-01-02 10:02:19 +00:00
2017-12-14 16:00:48 -08:00
2017-11-27 13:05:09 -08:00
2017-11-02 11:10:55 +01:00
2018-01-05 13:02:46 -08:00
2017-11-15 18:21:06 -08:00
2017-12-08 11:07:12 +01:00
2017-12-06 12:48:01 -06:00
2017-11-27 13:05:09 -08:00
2017-10-19 16:15:16 +02:00
2017-12-17 12:20:58 -08:00
2017-11-14 11:35:15 -08:00
2017-11-07 20:25:03 +01:00
2017-08-24 13:23:03 -07:00
2017-11-14 14:44:04 -08:00
2017-11-27 13:05:09 -08:00
2017-07-11 06:09:21 -04:00
2017-11-27 13:05:09 -08:00
2017-09-07 11:59:42 -07:00
2017-11-27 13:05:09 -08:00
2017-12-11 15:00:57 -05:00
2017-11-27 13:05:09 -08:00
2017-11-29 18:40:43 -08:00
2017-11-27 13:05:09 -08:00
2017-11-16 11:41:22 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-02 11:10:55 +01:00
2017-12-10 12:58:18 -08:00
2017-11-29 18:40:43 -08:00
2017-11-27 13:05:09 -08:00
2017-11-17 09:51:57 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2018-01-14 23:06:30 -05:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2018-01-22 10:05:11 -05:00
2017-11-27 16:45:11 -05:00
2017-12-14 16:00:49 -08:00
2017-11-27 13:05:09 -08:00
2017-11-02 11:10:55 +01:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-02 11:10:55 +01:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-12-14 11:14:52 +01:00
2017-12-06 18:23:27 -08:00
2017-11-21 15:57:05 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-29 16:46:48 +01:00
2017-09-06 17:27:26 -07:00
2017-11-30 18:38:47 -05:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-07-06 03:31:46 -04:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2018-01-05 12:59:32 -08:00
2017-11-17 11:54:55 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-09-04 19:05:15 -04:00
2017-11-17 12:54:01 -08:00
2017-11-16 12:50:35 -08:00
2017-11-02 11:10:55 +01:00
2017-10-13 16:18:33 -07:00
2017-10-03 17:54:25 -07:00
2017-11-14 15:32:19 -08:00
2017-11-15 18:21:06 -08:00
2017-11-02 11:10:55 +01:00
2017-11-17 12:54:01 -08:00
2017-11-17 11:54:55 -08:00
2017-12-15 18:53:22 -08:00
2017-11-15 18:21:04 -08:00
2017-11-14 15:32:19 -08:00
2017-11-02 11:10:55 +01:00
2017-07-03 21:13:25 -07:00
2017-11-17 16:56:17 -08:00
2018-01-03 10:13:36 -08:00
2017-11-15 08:08:36 -05:00
2017-11-17 12:54:01 -08:00
2017-11-15 18:21:04 -08:00
2017-11-17 12:54:01 -08:00
2017-11-02 11:10:55 +01:00
2017-11-07 10:32:44 +01:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-10 08:48:46 -05:00
2017-11-02 11:10:55 +01:00
2017-11-17 12:08:18 -08:00
2017-07-12 16:26:00 -07:00
2017-09-10 19:31:46 -04:00
2017-11-27 13:05:09 -08:00
2017-11-27 13:05:09 -08:00
2017-11-02 11:10:55 +01:00
2017-11-29 18:40:43 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-29 18:40:43 -08:00
2017-12-09 20:16:33 -05:00
2017-11-27 13:05:09 -08:00
2017-09-05 12:53:12 +02:00
2017-11-17 16:10:03 -08:00
2017-11-27 13:05:09 -08:00
2017-11-17 12:08:18 -08:00
2017-11-07 10:32:44 +01:00
2017-11-17 11:54:55 -08:00
2017-11-02 11:10:55 +01:00
2017-11-17 11:54:55 -08:00
2017-10-25 11:01:08 +02:00
2017-11-02 11:10:55 +01:00
2017-11-27 13:05:09 -08:00
2017-12-18 15:05:07 -05:00
2017-11-14 15:32:19 -08:00
2017-11-02 11:10:55 +01:00
2018-01-04 16:45:09 -08:00
2017-11-02 11:10:55 +01:00
2017-10-04 18:03:15 +11:00