0652035a57
In theory, compilers should be able to work this out themselves so we can use a simpler version based on the swab() helpers. I have verified that this works on all supported compiler versions (gcc-4.9 and up, clang-10 and up). Looking at the object code produced by gcc-11, I found that the impact is mostly a change in inlining decisions that lead to slightly larger code. In other cases, this version produces explicit byte swaps in place of separate byte access, or comparing against pre-swapped constants. While the source code is clearly simpler, I have not seen an indication of the new version actually producing better code on Arm, so maybe we want to skip this after all. From what I can tell, gcc recognizes the byteswap pattern in the byteshift.h header and can turn it into explicit instructions, but it does not turn a __builtin_bswap32() back into individual bytes when that would result in better output, e.g. when storing a byte-reversed constant. Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
35 lines
990 B
C
35 lines
990 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __ASM_GENERIC_UNALIGNED_H
|
|
#define __ASM_GENERIC_UNALIGNED_H
|
|
|
|
/*
|
|
* This is the most generic implementation of unaligned accesses
|
|
* and should work almost anywhere.
|
|
*/
|
|
#include <asm/byteorder.h>
|
|
|
|
/* Set by the arch if it can handle unaligned accesses in hardware. */
|
|
#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
|
|
# include <linux/unaligned/access_ok.h>
|
|
#endif
|
|
|
|
#if defined(__LITTLE_ENDIAN)
|
|
# ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
|
|
# include <linux/unaligned/le_struct.h>
|
|
# endif
|
|
# include <linux/unaligned/generic.h>
|
|
# define get_unaligned __get_unaligned_le
|
|
# define put_unaligned __put_unaligned_le
|
|
#elif defined(__BIG_ENDIAN)
|
|
# ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
|
|
# include <linux/unaligned/be_struct.h>
|
|
# endif
|
|
# include <linux/unaligned/generic.h>
|
|
# define get_unaligned __get_unaligned_be
|
|
# define put_unaligned __put_unaligned_be
|
|
#else
|
|
# error need to define endianess
|
|
#endif
|
|
|
|
#endif /* __ASM_GENERIC_UNALIGNED_H */
|