Miaohe Lin 04094226d6 mm/z3fold: fix z3fold_reclaim_page races with z3fold_free
Think about the below scenario:

CPU1				CPU2
z3fold_reclaim_page		z3fold_free
 spin_lock(&pool->lock)		 get_z3fold_header -- hold page_lock
 kref_get_unless_zero
				 kref_put--zhdr->refcount can be 1 now
 !z3fold_page_trylock
  kref_put -- zhdr->refcount is 0 now
   release_z3fold_page
    WARN_ON(!list_empty(&zhdr->buddy)); -- we're on buddy now!
    spin_lock(&pool->lock); -- deadlock here!

z3fold_reclaim_page might race with z3fold_free and will lead to pool lock
deadlock and zhdr buddy non-empty warning.  To fix this, defer getting the
refcount until page_lock is held just like what __z3fold_alloc does.  Note
this has the side effect that we won't break the reclaim if we meet a soon
to be released z3fold page now.

Link: https://lkml.kernel.org/r/20220429064051.61552-9-linmiaohe@huawei.com
Fixes: dcf5aedb24f8 ("z3fold: stricter locking and more careful reclaim")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2022-05-27 09:33:44 -07:00
..
2022-05-19 14:08:55 -07:00
2021-05-05 11:27:24 -07:00
2022-03-24 19:06:45 -07:00
2022-03-22 15:57:01 -07:00
2022-05-13 07:20:09 -07:00
2022-05-13 07:20:09 -07:00
2022-02-14 19:51:47 +01:00
2022-01-15 16:30:28 +02:00
2022-05-25 10:47:48 -07:00
2022-03-23 18:03:08 -07:00
2022-05-19 14:08:53 -07:00
2022-05-13 07:20:09 -07:00
2022-03-22 17:03:12 -07:00
2021-05-07 00:26:35 -07:00
2022-04-01 14:40:42 -04:00
2022-05-25 10:47:47 -07:00
2022-03-22 18:26:56 -07:00
2022-05-09 18:20:47 -07:00
2022-01-15 16:30:31 +02:00
2022-05-19 14:08:53 -07:00