Maíra Canal 8bd370cc3c pmdomain: bcm: bcm2835-power: check if the ASB register is equal to enable ... [ Upstream commit 2e75396f1df61e1f1d26d0d703fc7292c4ae4371 ] The commit c494a447c1 ("soc: bcm: bcm2835-power: Refactor ASB control") refactored the ASB control by using a general function to handle both the enable and disable. But this patch introduced a subtle regression: we need to check if !!(readl(base + reg) & ASB_ACK) == enable, not just check if (readl(base + reg) & ASB_ACK) == true. Currently, this is causing an invalid register state in V3D when unloading and loading the driver, because `bcm2835_asb_disable()` will return -ETIMEDOUT and `bcm2835_asb_power_off()` will fail to disable the ASB slave for V3D. Fixes: c494a447c1 ("soc: bcm: bcm2835-power: Refactor ASB control") Signed-off-by: Maíra Canal <mcanal@igalia.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20231024101251.6357-2-mcanal@igalia.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-11-28 17:07:16 +00:00
..
bcm63xx	arm64: bcmbca: Make BCM4908 drivers depend on ARCH_BCMBCA	2022-08-15 09:55:34 -07:00
brcmstb	soc: bcm: brcmstb: biuctrl: fix of_iomap leak	2023-05-11 23:03:12 +09:00
bcm2835-power.c	pmdomain: bcm: bcm2835-power: check if the ASB register is equal to enable	2023-11-28 17:07:16 +00:00
Kconfig
Makefile
raspberrypi-power.c