Early boot kernel logs are enabled with earlycon cmdline option.
If earlycon device is passed to earlycon as a parameter with "=dev",
it is considered, otherwise kernel relies on stdout-path for the device.
Since this device can be different for different chipsets, sharing the
same compiled binary, the value passed to earlycon parameter can
be wrong for some of the chipsets, which is leading to issues like
invalid address access or garbled logs in some cases.
To fix this, add earlycon without any value so that the right
device can be picked from stdout-path. For chipsets not having
stdout-path defined, keep passing earlycon value if it is explicitly
defined in target bazel file.
Also, remove default earlycon param value for Pineapple family of
chipsets to avoid adding wrong address for Cliffs, Volcano SoCs.
Change-Id: If40d23a3916f1f148e26033d67408279dfca5493
Signed-off-by: Naini Singh <quic_nainsing@quicinc.com>
Signed-off-by: Naman Jain <quic_namajain@quicinc.com>
Currently, there are a few places where we use Bazel's native genrule
rule to generate files that consist of simple strings (usually with
cat << EOF or echo "str" >> "$@" semantics). It was recently pointed
out to us that the Skylib library (already available from Kleaf) has
a "write_file" rule which is better than our genrule method for
creating files from strings.
It's better because it has a simpler interface, does not rely on any
Starlark-external tools (i.e. bash), and does not require all of the
strings to be formatted in one operation which makes the rule
slightly more readable.
Replace file-creating genrules where it makes sense to do so. This
change has no impact on actual build logic as the output files are
logically identical.
Change-Id: I2cef369e299d42b2677ddea833c43d9c80eff32c
Signed-off-by: John Moon <quic_johmoo@quicinc.com>
Kleaf test_mapping rules are no longer used upstream and were being
skipped in our builds anyway.
Remove the test_mapping rules.
Change-Id: If8689f4572b1d1dce2c8ba03075444fa3af7d86b
Signed-off-by: John Moon <quic_johmoo@quicinc.com>
Handle the super.img generation cleanly from the build. super image
generated has no dependency on vendor and system dlkms as the allyes
variant has no ko's generated. We need to generate a proper super image
as we validate the super image before flashing.
Change-Id: I74991610ec64564663983a3ca98e3d16bd4039f5
Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
avb signing was done in the dist target with commit (9a13ebd43a
"ANDROID: build: msm_kernel_le: Make boot image a chained partition").
Move this from the dist target so that the signing is done correct.
Change-Id: I51a48baaa3ad07773f6a696e75ee4899f9c10277
Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
Convert the final boot image generated into a "chained partition" [1],
which is accomplished by calling `avbtool add_hash_footer` on it.
[1]: https://android.googlesource.com/platform/external/avb/+/master/README.md
Change-Id: I91c7f85791edc5c8584ef7237eea012810e5ed75
Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
This reverts commit 7d9197e99b.
Reverting to avoid removing debug information from modules.
Change-Id: I01be6f1b616ebde8578c40fc63f67a5d3170cf27
Signed-off-by: John Moon <quic_johmoo@quicinc.com>
Change name of the target to pineapple-allyes from pineapple.allyes.
Change-Id: I84525dda8efe64b9a031dda9e261c0a563cd979e
Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
Currently, a kernel_compile_commands rule can be defined if the user
passes define_compile_commands = True to the definition macros. This
was to avoid enabling the interceptor on the kernel_build when it was
not necessary.
With a recent change upstream, the interceptor is no longer needed to
use compile_commands. Therefore, let's remove the argument and always
define the rule. That way, users can always generate the
compile_commands.json file if they wish.
Change-Id: I723756b31a2ec4582fee804386406194f5ce77d8
Signed-off-by: John Moon <quic_johmoo@quicinc.com>
Currently, DO_NOT_STRIP_MODULES is used to signal when and when not
to strip kernel modules. A recent upstream change removes this config
option by unsetting it during the Bazel build in Kleaf.
Instead of using the deprecated build.config method, use the
kernel_build attribute "strip_modules". Set to True in our builds.
Change-Id: I918758ce8758234bcc13a683c2b39fc639678229
Signed-off-by: John Moon <quic_johmoo@quicinc.com>
Add dummy file generating rule to the list of targets to be run.
Change-Id: I62717451f87ed476306b687e8751e605fcab6bb1
Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
Changing dist directory from target.le-variant to target-variant.
This change is to keep out folder structure the same.
Change-Id: I8463065a0f2e683b2df3c311dc0a62ce19105bbf
Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
Currently, only legacy build.sh support exists for Pineapple allyes config.
Add Bazel support for these builds.
Change-Id: I6ee869762f9061c433383fe720769e0dd874facf
Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
