android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: operation: allocate response before setting result

Browse Source 
Make sure to allocate a response message before setting the operation
result.

This is needed to handle cancellation of incoming operations.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2015-07-01 12:37:30 +02:00 committed by Greg Kroah-Hartman
parent 1635304d63
commit fde7382b47
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/greybus/operation.c
View File

@ -662,6 +662,12 @@ static int gb_operation_response_send(struct gb_operation *operation,
struct gb_connection *connection = operation->connection;
int ret;
if (!operation->response &&
!gb_operation_is_unidirectional(operation)) {
if (!gb_operation_response_alloc(operation, 0))
return -ENOMEM;
}
/* Record the result */
if (!gb_operation_result_set(operation, errno)) {
dev_err(&connection->dev, "request result already set\n");
@ -672,11 +678,6 @@ static int gb_operation_response_send(struct gb_operation *operation,
if (gb_operation_is_unidirectional(operation))
return 0;
if (!operation->response) {
if (!gb_operation_response_alloc(operation, 0))
return -ENOMEM;
}
/* Reference will be dropped when message has been sent. */
gb_operation_get(operation);