From 7d105686913f6238caa815aa17258d497cf7ab10 Mon Sep 17 00:00:00 2001 From: Shivnandan Kumar Date: Fri, 14 Oct 2022 12:20:15 +0530 Subject: [PATCH] drivers: dcvs: memlat: check return value of devm_protocol_get Validate return value of devm_protocol_get. Currently only NULL pointer is checked but we should also check if returned pointer is valid pointer or not. If it is not valid pointer then it can lead to crash. Change-Id: If7c6e275bae0df42511cc915215bfe434d2053e3 Signed-off-by: Shivnandan Kumar --- drivers/soc/qcom/dcvs/memlat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/dcvs/memlat.c b/drivers/soc/qcom/dcvs/memlat.c index 9b4b60d1d99b..dace24e7a370 100644 --- a/drivers/soc/qcom/dcvs/memlat.c +++ b/drivers/soc/qcom/dcvs/memlat.c @@ -1427,8 +1427,8 @@ int cpucp_memlat_init(struct scmi_device *sdev) return -EINVAL; ops = sdev->handle->devm_protocol_get(sdev, SCMI_PROTOCOL_MEMLAT, &ph); - if (!ops) - return -ENODEV; + if (IS_ERR(ops)) + return PTR_ERR(ops); mutex_lock(&memlat_lock); memlat_data->ph = ph;