android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Btrfs: make inode.c:submit_compressed_extents() return void

Browse Source 
Its return value is completely ignored by its single caller and it's
useless anyway, since errors are indicated through SetPageError and
the bit AS_EIO set in the flags of the inode's mapping. The caller
can't do anything with the value, as it's invoked from a workqueue
task and not by the task calling filemap_fdatawrite_range (which calls
the writepages address space callback, which in turn calls the inode's
fill_delalloc callback).

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
This commit is contained in:
Filipe Manana 2014-10-06 22:14:26 +01:00 committed by Chris Mason
parent 3d7a820f71
commit dec8f17563
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fs/btrfs/inode.c
View File

@ -655,7 +655,7 @@ static void free_async_extent_pages(struct async_extent *async_extent)
* queued. We walk all the async extents created by compress_file_range * queued. We walk all the async extents created by compress_file_range
* and send them down to the disk. * and send them down to the disk.
*/ */
static noinline int submit_compressed_extents(struct inode *inode, static noinline void submit_compressed_extents(struct inode *inode,
struct async_cow *async_cow) struct async_cow *async_cow)
{ {
struct async_extent *async_extent; struct async_extent *async_extent;
@ -667,9 +667,6 @@ static noinline int submit_compressed_extents(struct inode *inode,
struct extent_io_tree *io_tree; struct extent_io_tree *io_tree;
int ret = 0; int ret = 0;
if (list_empty(&async_cow->extents))
return 0;
again: again:
while (!list_empty(&async_cow->extents)) { while (!list_empty(&async_cow->extents)) {
async_extent = list_entry(async_cow->extents.next, async_extent = list_entry(async_cow->extents.next,
@ -841,7 +838,7 @@ static noinline int submit_compressed_extents(struct inode *inode,
kfree(async_extent); kfree(async_extent);
cond_resched(); cond_resched();
} }
return 0; return;
out_free_reserve: out_free_reserve:
btrfs_free_reserved_extent(root, ins.objectid, ins.offset, 1); btrfs_free_reserved_extent(root, ins.objectid, ins.offset, 1);
out_free: out_free: