android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ACPI: x86: s2idle: Post-increment variables when getting constraints

Browse Source 
[ Upstream commit 3c6b1212d20bbbffcad5709ab0f2d5ed9b5859a8 ]

When code uses a pre-increment it makes the reader question "why".
In the constraint fetching code there is no reason for the variables
to be pre-incremented so adjust to post-increment.
No intended functional changes.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Stable-dep-of: 9cc8cd086f05 ("ACPI: x86: s2idle: Fix a logic error parsing AMD constraints table")
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Mario Limonciello 2023-08-18 14:40:02 -05:00 committed by Greg Kroah-Hartman
parent 8ee6d04ef2
commit a99f32b81c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/acpi/x86/s2idle.c
View File

@ -122,13 +122,13 @@ static void lpi_device_get_constraints_amd(void)
acpi_handle_debug(lps0_device_handle, acpi_handle_debug(lps0_device_handle,
"LPI: constraints list begin:\n"); "LPI: constraints list begin:\n");
for (j = 0; j < package->package.count; ++j) { for (j = 0; j < package->package.count; j++) {
union acpi_object *info_obj = &package->package.elements[j]; union acpi_object *info_obj = &package->package.elements[j];
struct lpi_device_constraint_amd dev_info = {}; struct lpi_device_constraint_amd dev_info = {};
struct lpi_constraints *list; struct lpi_constraints *list;
acpi_status status; acpi_status status;
for (k = 0; k < info_obj->package.count; ++k) { for (k = 0; k < info_obj->package.count; k++) {
union acpi_object *obj = &info_obj->package.elements[k]; union acpi_object *obj = &info_obj->package.elements[k];
list = &lpi_constraints_table[lpi_constraints_table_size]; list = &lpi_constraints_table[lpi_constraints_table_size];
@ -213,7 +213,7 @@ static void lpi_device_get_constraints(void)
if (!package) if (!package)
continue; continue;
for (j = 0; j < package->package.count; ++j) { for (j = 0; j < package->package.count; j++) {
union acpi_object *element = union acpi_object *element =
&(package->package.elements[j]); &(package->package.elements[j]);
@ -245,7 +245,7 @@ static void lpi_device_get_constraints(void)
constraint->min_dstate = -1; constraint->min_dstate = -1;
for (j = 0; j < package_count; ++j) { for (j = 0; j < package_count; j++) {
union acpi_object *info_obj = &info.package[j]; union acpi_object *info_obj = &info.package[j];
union acpi_object *cnstr_pkg; union acpi_object *cnstr_pkg;
union acpi_object *obj; union acpi_object *obj;