android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: sc16is7xx: remove wasteful static buffer in sc16is7xx_regmap_name()

Browse Source 
commit 6bcab3c8acc88e265c570dea969fd04f137c8a4c upstream.

Using a static buffer inside sc16is7xx_regmap_name() was a convenient and
simple way to set the regmap name without having to allocate and free a
buffer each time it is called. The drawback is that the static buffer
wastes memory for nothing once regmap is fully initialized.

Remove static buffer and use constant strings instead.

This also avoids a truncation warning when using "%d" or "%u" in snprintf
which was flagged by kernel test robot.

Fixes: 3837a0379533 ("serial: sc16is7xx: improve regmap debugfs by using one regmap per port")
Cc:  <stable@vger.kernel.org> # 6.1.x: 3837a03 serial: sc16is7xx: improve regmap debugfs by using one regmap per port
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20231211171353.2901416-2-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Hugo Villeneuve 2023-12-11 12:13:48 -05:00 committed by Greg Kroah-Hartman
parent 45ec1b7acc
commit 9bcb019aee
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/tty/serial/sc16is7xx.c
View File

@ -1698,13 +1698,15 @@ static struct regmap_config regcfg = {
.max_register = SC16IS7XX_EFCR_REG,
};
static const char *sc16is7xx_regmap_name(unsigned int port_id)
static const char *sc16is7xx_regmap_name(u8 port_id)
{
static char buf[6];
snprintf(buf, sizeof(buf), "port%d", port_id);
return buf;
switch (port_id) {
case 0: return "port0";
case 1: return "port1";
default:
WARN_ON(true);
return NULL;
}
}
static unsigned int sc16is7xx_regmap_port_mask(unsigned int port_id)