android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

btrfs: unify the error handling of btrfs_read_buffer()

Browse Source 
There is one oddball error handling of btrfs_read_buffer():

	ret = btrfs_read_buffer(tmp, gen, parent_level - 1, &first_key);
	if (!ret) {
		*eb_ret = tmp;
		return 0;
	}
	free_extent_buffer(tmp);
	btrfs_release_path(p);
	return -EIO;

While all other call sites check the error first.  Unify the behavior.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2022-02-22 15:41:20 +08:00 committed by David Sterba
parent 4eb150d612
commit 9a4ffa1bd6
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/btrfs/ctree.c
View File

@ -1438,13 +1438,13 @@ read_block_for_search(struct btrfs_root *root, struct btrfs_path *p,
/* now we're allowed to do a blocking uptodate check */ /* now we're allowed to do a blocking uptodate check */
ret = btrfs_read_buffer(tmp, gen, parent_level - 1, &first_key); ret = btrfs_read_buffer(tmp, gen, parent_level - 1, &first_key);
if (!ret) { if (ret) {
*eb_ret = tmp; free_extent_buffer(tmp);
return 0; btrfs_release_path(p);
return -EIO;
} }
free_extent_buffer(tmp); *eb_ret = tmp;
btrfs_release_path(p); return 0;
return -EIO;
} }
/* /*