android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coresight: tmc: etf: Free its buffer and set NULL when etf can't be enabled

Browse Source 
In function tmc_enable_etf_sink_sysfs, the local variable buf
was allocated and assigned to drvdata->buffer, and buf will be
freed because etf can't be enabled, but drvdata->buffer
still point to the address.
So in function tmc_read_unprepare_etb, beacause drvdata->mode
is CS_MODE_DISABLED, local variable buf was assigned by
drvdata->buf and free again.

Change-Id: I7d25e7db0a983fc134e8d8dfb954936233f0d167
Signed-off-by: yingdeng <quic_yingdeng@quicinc.com>
This commit is contained in:
yingdeng 2024-08-09 16:59:09 +08:00 committed by Yingchao Deng
parent 9cfdeb74ee
commit 8a01c3ed0f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/hwtracing/coresight/coresight-tmc-etf.c
View File

@ -247,7 +247,8 @@ static int tmc_enable_etf_sink_sysfs(struct coresight_device *csdev)
atomic_inc(csdev->refcnt); atomic_inc(csdev->refcnt);
} else { } else {
/* Free up the buffer if we failed to enable */ /* Free up the buffer if we failed to enable */
used = false; kfree(drvdata->buf);
drvdata->buf = NULL;
} }
out: out:
spin_unlock_irqrestore(&drvdata->spinlock, flags); spin_unlock_irqrestore(&drvdata->spinlock, flags);