android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pci: msm: Fix incorrect spinlock usage

Browse Source 
When CONFIG_TRAC_IRQFLAGS Kconfig is enabled,
raw_check_bogus_irq_restore() is checked to detect situation
where interrupts are already enabled while trying to restore it.
Due to nested usage of locking, there is WARN_ONCE() seen.

To avoid this change spin_lock_irq & spin_unlock_irq to
spin_lock_irqsave & spin_unlock_irqrestore respectively.

Change-Id: I2471e038b1342603e892a3e9883e223f68a55ae8
Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
This commit is contained in:
Krishna chaitanya chundru 2023-09-27 07:26:49 +05:30 committed by Krishna Chaitanya Chundru
parent ff65a6bf3c
commit 8630b6b648
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/pci/controller/pci-msm.c
View File

@ -9525,7 +9525,7 @@ static int msm_pcie_drv_suspend(struct msm_pcie_dev_t *pcie_dev,
struct msm_pcie_drv_info *drv_info = pcie_dev->drv_info;
struct msm_pcie_clk_info_t *clk_info;
int ret, i;
unsigned long irqsave_flags;
unsigned long irqsave_flags, cfg_irqsave_flags;
u32 ab = 0, ib = 0;
/* If CESTA is available then drv is always supported */
@ -9556,9 +9556,9 @@ static int msm_pcie_drv_suspend(struct msm_pcie_dev_t *pcie_dev,
pcie_dev->user_suspend = true;
set_bit(pcie_dev->rc_idx, &pcie_drv.rc_drv_enabled);
spin_lock_irqsave(&pcie_dev->irq_lock, irqsave_flags);
spin_lock_irq(&pcie_dev->cfg_lock);
spin_lock_irqsave(&pcie_dev->cfg_lock, cfg_irqsave_flags);
pcie_dev->cfg_access = false;
spin_unlock_irq(&pcie_dev->cfg_lock);
spin_unlock_irqrestore(&pcie_dev->cfg_lock, cfg_irqsave_flags);
spin_unlock_irqrestore(&pcie_dev->irq_lock, irqsave_flags);
mutex_lock(&pcie_dev->setup_lock);
mutex_lock(&pcie_dev->aspm_lock);