android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

connector: use nlmsg_put() instead of NLMSG_PUT() macro.

Browse Source 
The NLMSG_PUT() macro contains a hidden goto which makes the code hard
to audit and very error prone.

While been there also use the inline function nlmsg_data() instead of the
NLMSG_DATA() macro to do explicit type checking.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Javier Martinez Canillas 2012-06-26 05:41:24 +00:00 committed by David S. Miller
parent 4a9fbcc6d6
commit 85c931665d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/connector/connector.c
View File

@ -101,19 +101,19 @@ int cn_netlink_send(struct cn_msg *msg, u32 __group, gfp_t gfp_mask)
if (!skb) if (!skb)
return -ENOMEM; return -ENOMEM;
nlh = NLMSG_PUT(skb, 0, msg->seq, NLMSG_DONE, size - sizeof(*nlh)); nlh = nlmsg_put(skb, 0, msg->seq, NLMSG_DONE, size - sizeof(*nlh), 0);
if (!nlh) {
kfree_skb(skb);
return -EMSGSIZE;
}
data = NLMSG_DATA(nlh); data = nlmsg_data(nlh);
memcpy(data, msg, sizeof(*data) + msg->len); memcpy(data, msg, sizeof(*data) + msg->len);
NETLINK_CB(skb).dst_group = group; NETLINK_CB(skb).dst_group = group;
return netlink_broadcast(dev->nls, skb, 0, group, gfp_mask); return netlink_broadcast(dev->nls, skb, 0, group, gfp_mask);
nlmsg_failure:
kfree_skb(skb);
return -EINVAL;
} }
EXPORT_SYMBOL_GPL(cn_netlink_send); EXPORT_SYMBOL_GPL(cn_netlink_send);