android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: scsi_devinfo: cleanly zero-pad devinfo strings

Browse Source 
Cleanly fill memory for "vendor" and "model" with 0-bytes for the
"compatible" case rather than adding only a single 0 byte.  This
simplifies the devinfo code a a bit, and avoids mistakes in other places
of the code (not in current upstream, but we had one such mistake in the
SUSE kernel).

[mkp: applied by hand and added braces]

Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Martin Wilck 2017-11-27 23:47:35 +01:00 committed by Martin K. Petersen
parent ba69ead9e9
commit 81df022b68
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/scsi/scsi_devinfo.c
View File

@ -34,7 +34,6 @@ struct scsi_dev_info_list_table {
}; };
static const char spaces[] = " "; /* 16 of them */
static blist_flags_t scsi_default_dev_flags; static blist_flags_t scsi_default_dev_flags;
static LIST_HEAD(scsi_dev_info_list); static LIST_HEAD(scsi_dev_info_list);
static char scsi_dev_flags[256]; static char scsi_dev_flags[256];
@ -298,20 +297,13 @@ static void scsi_strcpy_devinfo(char *name, char *to, size_t to_length,
size_t from_length; size_t from_length;
from_length = strlen(from); from_length = strlen(from);
strncpy(to, from, min(to_length, from_length)); /* This zero-pads the destination */
if (from_length < to_length) { strncpy(to, from, to_length);
if (compatible) { if (from_length < to_length && !compatible) {
/* /*
* NUL terminate the string if it is short. * space pad the string if it is short.
*/ */
to[from_length] = '\0'; memset(&to[from_length], ' ', to_length - from_length);
} else {
/*
* space pad the string if it is short.
*/
strncpy(&to[from_length], spaces,
to_length - from_length);
}
} }
if (from_length > to_length) if (from_length > to_length)
printk(KERN_WARNING "%s: %s string '%s' is too long\n", printk(KERN_WARNING "%s: %s string '%s' is too long\n",