android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: dcvs: memlat: check return value of devm_protocol_get

Browse Source 
Validate return value of devm_protocol_get.
Currently only NULL pointer is checked but
we should also check if returned pointer is
valid pointer or not. If it is not valid pointer
then it can lead to crash.

Change-Id: If7c6e275bae0df42511cc915215bfe434d2053e3
Signed-off-by: Shivnandan Kumar <quic_kshivnan@quicinc.com>
This commit is contained in:
Shivnandan Kumar 2022-10-14 12:20:15 +05:30 committed by Gerrit - the friendly Code Review server
parent f6646ebd13
commit 7d10568691
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/soc/qcom/dcvs/memlat.c
View File

@ -1427,8 +1427,8 @@ int cpucp_memlat_init(struct scmi_device *sdev)
return -EINVAL;
ops = sdev->handle->devm_protocol_get(sdev, SCMI_PROTOCOL_MEMLAT, &ph);
if (!ops)
return -ENODEV;
if (IS_ERR(ops))
return PTR_ERR(ops);
mutex_lock(&memlat_lock);
memlat_data->ph = ph;