android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pwm: ab8500: Fix error code in probe()

Browse Source 
[ Upstream commit cdcffafc4d845cc0c6392cba168c7a942734cce7 ]

This code accidentally return positive EINVAL instead of negative
-EINVAL.

Fixes: eb41f33458 ("pwm: ab8500: Fix register offset calculation to not depend on probe order")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter 2023-05-22 14:07:42 +03:00 committed by Greg Kroah-Hartman
parent 61aad933e5
commit 75439e6cd2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pwm/pwm-ab8500.c
View File

@ -96,7 +96,7 @@ static int ab8500_pwm_probe(struct platform_device *pdev)
int err; int err;
if (pdev->id < 1 || pdev->id > 31) if (pdev->id < 1 || pdev->id > 31)
return dev_err_probe(&pdev->dev, EINVAL, "Invalid device id %d\n", pdev->id); return dev_err_probe(&pdev->dev, -EINVAL, "Invalid device id %d\n", pdev->id);
/* /*
* Nothing to be done in probe, this is required to get the * Nothing to be done in probe, this is required to get the