From 70fdaa07de739baa01b3d5597d8e542c86f558e1 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Thu, 29 Feb 2024 10:13:14 -0800 Subject: [PATCH] Revert "ANDROID: Build null_blk and scsi_debug as kernel modules" Revert commit 9b476ebe99ad in preparation of making this a Pixel-specific change. A disadvantage of building null_blk and scsi_debug as kernel modules for all vendors is that this causes these kernel modules to be loaded by the init process during boot and there is no vendor-independent mechanism for preventing kernel modules to be loaded. Bug: 323406846 Change-Id: I6e7bcdd9fd06194bbc134ee52251b6ae9a3c1477 Signed-off-by: Bart Van Assche --- arch/arm64/configs/gki_defconfig | 2 -- arch/x86/configs/gki_defconfig | 2 -- modules.bzl | 5 ----- 3 files changed, 9 deletions(-) diff --git a/arch/arm64/configs/gki_defconfig b/arch/arm64/configs/gki_defconfig index bc18ada0bd54..dbf1e1ca23fd 100644 --- a/arch/arm64/configs/gki_defconfig +++ b/arch/arm64/configs/gki_defconfig @@ -309,7 +309,6 @@ CONFIG_ARM_SCPI_PROTOCOL=y # CONFIG_ARM_SCPI_POWER_DOMAIN is not set # CONFIG_EFI_ARMSTUB_DTB_LOADER is not set CONFIG_GNSS=y -CONFIG_BLK_DEV_NULL_BLK=m CONFIG_ZRAM=m CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_LOOP_MIN_COUNT=16 @@ -323,7 +322,6 @@ CONFIG_UID_SYS_STATS=y CONFIG_SCSI=y # CONFIG_SCSI_PROC_FS is not set CONFIG_BLK_DEV_SD=y -CONFIG_SCSI_DEBUG=m CONFIG_MD=y CONFIG_BLK_DEV_DM=y CONFIG_DM_CRYPT=y diff --git a/arch/x86/configs/gki_defconfig b/arch/x86/configs/gki_defconfig index 8090b1ca2a28..8330afe50d28 100644 --- a/arch/x86/configs/gki_defconfig +++ b/arch/x86/configs/gki_defconfig @@ -295,7 +295,6 @@ CONFIG_FW_LOADER_USER_HELPER=y # CONFIG_FW_CACHE is not set CONFIG_GNSS=y CONFIG_OF=y -CONFIG_BLK_DEV_NULL_BLK=m CONFIG_ZRAM=m CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_LOOP_MIN_COUNT=16 @@ -309,7 +308,6 @@ CONFIG_UID_SYS_STATS=y CONFIG_SCSI=y # CONFIG_SCSI_PROC_FS is not set CONFIG_BLK_DEV_SD=y -CONFIG_SCSI_DEBUG=m CONFIG_MD=y CONFIG_BLK_DEV_DM=y CONFIG_DM_CRYPT=y diff --git a/modules.bzl b/modules.bzl index ad71a36c4ff5..52d92225aab4 100644 --- a/modules.bzl +++ b/modules.bzl @@ -8,9 +8,6 @@ This module contains a full list of kernel modules _COMMON_GKI_MODULES_LIST = [ # keep sorted - "crypto/crct10dif_common.ko", - "crypto/crct10dif_generic.ko", - "drivers/block/null_blk/null_blk.ko", "drivers/block/zram/zram.ko", "drivers/bluetooth/btbcm.ko", "drivers/bluetooth/btqca.ko", @@ -38,12 +35,10 @@ _COMMON_GKI_MODULES_LIST = [ "drivers/net/usb/rtl8150.ko", "drivers/net/usb/usbnet.ko", "drivers/net/wwan/wwan.ko", - "drivers/scsi/scsi_debug.ko", "drivers/usb/class/cdc-acm.ko", "drivers/usb/serial/ftdi_sio.ko", "drivers/usb/serial/usbserial.ko", "kernel/kheaders.ko", - "lib/crc-t10dif.ko", "lib/crypto/libarc4.ko", "mm/zsmalloc.ko", "net/6lowpan/6lowpan.ko",