android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASoC: tas6424: Fix the error handling of tas6424_i2c_probe()

Browse Source 
After enabling the regulator, The driver should disable the regulator
when failing at probing.

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Link: https://lore.kernel.org/r/20220510153251.1741210-6-zheyuma97@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Zheyu Ma 2022-05-10 23:32:50 +08:00 committed by Mark Brown
parent ef1878fd0c
commit 68cacb5cf5
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/soc/codecs/tas6424.c
View File

@ -756,7 +756,7 @@ static int tas6424_i2c_probe(struct i2c_client *client)
TAS6424_RESET, TAS6424_RESET);
if (ret) {
dev_err(dev, "unable to reset device: %d\n", ret);
return ret;
goto disable_regs;
}
INIT_DELAYED_WORK(&tas6424->fault_check_work, tas6424_fault_check_work);
@ -765,10 +765,14 @@ static int tas6424_i2c_probe(struct i2c_client *client)
tas6424_dai, ARRAY_SIZE(tas6424_dai));
if (ret < 0) {
dev_err(dev, "unable to register codec: %d\n", ret);
return ret;
goto disable_regs;
}
return 0;
disable_regs:
regulator_bulk_disable(ARRAY_SIZE(tas6424->supplies), tas6424->supplies);
return ret;
}
static int tas6424_i2c_remove(struct i2c_client *client)