android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ufs: replace ll_rw_block()

Browse Source 
ll_rw_block() is not safe for the sync read path because it cannot
guarantee that submitting read IO if the buffer has been locked. We
could get false positive EIO after wait_on_buffer() if the buffer has
been locked by others. So stop using ll_rw_block() in ufs.

Link: https://lkml.kernel.org/r/20220901133505.2510834-12-yi.zhang@huawei.com
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Zhang Yi 2022-09-01 21:35:02 +08:00 committed by Andrew Morton
parent 59a16786fa
commit 6799b69831
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/ufs/balloc.c
View File

@ -295,14 +295,10 @@ static void ufs_change_blocknr(struct inode *inode, sector_t beg,
if (!buffer_mapped(bh)) if (!buffer_mapped(bh))
map_bh(bh, inode->i_sb, oldb + pos); map_bh(bh, inode->i_sb, oldb + pos);
if (!buffer_uptodate(bh)) { if (bh_read(bh, 0) < 0) {
ll_rw_block(REQ_OP_READ, 1, &bh); ufs_error(inode->i_sb, __func__,
wait_on_buffer(bh); "read of block failed\n");
if (!buffer_uptodate(bh)) { break;
ufs_error(inode->i_sb, __func__,
"read of block failed\n");
break;
}
} }
UFSD(" change from %llu to %llu, pos %u\n", UFSD(" change from %llu to %llu, pos %u\n",