android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ANDROID: 16K: Avoid and document padding madvise lock warning

Browse Source 
Usually to modify vm_flags we need to take exclusive mmap_lock but here
only have the lock in read mode, to avoid all DONTNEED/DONTNEED_LOCKED
calls needing the write lock.

A race to the flags update can only happen with another MADV_DONTNEED on
the same process and same range (VMA).

In practice, this specific scenario is not possible  because the action
that could cause it is usually performed at most once per VMA and only by the dynamic linker.

Forego protection for this case, to avoid penalties in the common cases.

Bug: 344634072
Change-Id: I54ac1f204e0445291f3df3872fbaa16b37722812
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
This commit is contained in:
Kalesh Singh 2024-06-03 16:41:03 -07:00
parent ec795e4eaa
commit 65aed0e2f7
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
mm/pgsize_migration.c
View File

@ -116,8 +116,22 @@ void vma_set_pad_pages(struct vm_area_struct *vma,
if (!is_pgsize_migration_enabled())
return;
vm_flags_clear(vma, VM_PAD_MASK);
vm_flags_set(vma, nr_pages << VM_PAD_SHIFT);
/*
* Usually to modify vm_flags we need to take exclusive mmap_lock but here
* only have the lock in read mode, to avoid all DONTNEED/DONTNEED_LOCKED
* calls needing the write lock.
*
* A race to the flags update can only happen with another MADV_DONTNEED on
* the same process and same range (VMA).
*
* In practice, this specific scenario is not possible because the action that
* could cause it is usually performed at most once per VMA and only by the
* dynamic linker.
*
* Forego protection for this case, to avoid penalties in the common cases.
*/
__vm_flags_mod(vma, 0, VM_PAD_MASK);
__vm_flags_mod(vma, nr_pages << VM_PAD_SHIFT, 0);
}
unsigned long vma_pad_pages(struct vm_area_struct *vma)