android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

revert "vanishing ioctl handler debugging"

Browse Source 
Revert my do_ioctl() debugging patch: Paul fixed the bug.

Cc: Paul Fulghum <paulkf@microgate.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Andrew Morton 2007-07-15 23:41:02 -07:00 committed by Linus Torvalds
parent 77ec739d8d
commit 64d67d2177
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
fs/ioctl.c
View File

@ -12,7 +12,6 @@
#include <linux/fs.h> #include <linux/fs.h>
#include <linux/security.h> #include <linux/security.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/kallsyms.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include <asm/ioctls.h> #include <asm/ioctls.h>
@ -21,7 +20,6 @@ static long do_ioctl(struct file *filp, unsigned int cmd,
unsigned long arg) unsigned long arg)
{ {
int error = -ENOTTY; int error = -ENOTTY;
void *f;
if (!filp->f_op) if (!filp->f_op)
goto out; goto out;
@ -31,16 +29,10 @@ static long do_ioctl(struct file *filp, unsigned int cmd,
if (error == -ENOIOCTLCMD) if (error == -ENOIOCTLCMD)
error = -EINVAL; error = -EINVAL;
goto out; goto out;
} else if ((f = filp->f_op->ioctl)) { } else if (filp->f_op->ioctl) {
lock_kernel(); lock_kernel();
if (!filp->f_op->ioctl) { error = filp->f_op->ioctl(filp->f_path.dentry->d_inode,
printk("%s: ioctl %p disappeared\n", __FUNCTION__, f); filp, cmd, arg);
print_symbol("symbol: %s\n", (unsigned long)f);
dump_stack();
} else {
error = filp->f_op->ioctl(filp->f_path.dentry->d_inode,
filp, cmd, arg);
}
unlock_kernel(); unlock_kernel();
} }