android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kdb: kdb_support: mark expected switch fall-throughs

Browse Source 
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced the code comments with
a proper "fall through" annotation, which is what GCC is expecting
to find.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
This commit is contained in:
Gustavo A. R. Silva 2018-08-04 21:48:44 -05:00 committed by Daniel Thompson
parent 01cb37351b
commit 646558ff16
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kernel/debug/kdb/kdb_support.c
View File

@ -432,7 +432,7 @@ int kdb_getphysword(unsigned long *word, unsigned long addr, size_t size)
*word = w8; *word = w8;
break; break;
} }
/* drop through */ /* fall through */
default: default:
diag = KDB_BADWIDTH; diag = KDB_BADWIDTH;
kdb_printf("kdb_getphysword: bad width %ld\n", (long) size); kdb_printf("kdb_getphysword: bad width %ld\n", (long) size);
@ -481,7 +481,7 @@ int kdb_getword(unsigned long *word, unsigned long addr, size_t size)
*word = w8; *word = w8;
break; break;
} }
/* drop through */ /* fall through */
default: default:
diag = KDB_BADWIDTH; diag = KDB_BADWIDTH;
kdb_printf("kdb_getword: bad width %ld\n", (long) size); kdb_printf("kdb_getword: bad width %ld\n", (long) size);
@ -525,7 +525,7 @@ int kdb_putword(unsigned long addr, unsigned long word, size_t size)
diag = kdb_putarea(addr, w8); diag = kdb_putarea(addr, w8);
break; break;
} }
/* drop through */ /* fall through */
default: default:
diag = KDB_BADWIDTH; diag = KDB_BADWIDTH;
kdb_printf("kdb_putword: bad width %ld\n", (long) size); kdb_printf("kdb_putword: bad width %ld\n", (long) size);