android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] omap3isp: Fix histogram regions

Browse Source 
This patch fixes a bug which causes all histogram regions to start in the
top left corner of the image. The histogram region coordinates are 16 bit
values which share a 32 bit register. The bug is due to the region end
value assignments overwriting the region start values with zero.

Signed-off-by: Johannes Schellen <Johannes.Schellen@rwth-aachen.de>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Johannes Schellen
2013-01-11 12:00:19 -03:00
committed by Mauro Carvalho Chehab
parent cf2b4cf661
commit 58bc8b7e38
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/media/platform/omap3isp/isphist.c
View File

@ -114,14 +114,14 @@ static void hist_setup_regs(struct ispstat *hist, void *priv)
/* Regions size and position */ /* Regions size and position */
for (c = 0; c < OMAP3ISP_HIST_MAX_REGIONS; c++) { for (c = 0; c < OMAP3ISP_HIST_MAX_REGIONS; c++) {
if (c < conf->num_regions) { if (c < conf->num_regions) {
reg_hor[c] = conf->region[c].h_start << reg_hor[c] = (conf->region[c].h_start <<
ISPHIST_REG_START_SHIFT; ISPHIST_REG_START_SHIFT)
reg_hor[c] = conf->region[c].h_end << | (conf->region[c].h_end <<
ISPHIST_REG_END_SHIFT; ISPHIST_REG_END_SHIFT);
reg_ver[c] = conf->region[c].v_start << reg_ver[c] = (conf->region[c].v_start <<
ISPHIST_REG_START_SHIFT; ISPHIST_REG_START_SHIFT)
reg_ver[c] = conf->region[c].v_end << | (conf->region[c].v_end <<
ISPHIST_REG_END_SHIFT; ISPHIST_REG_END_SHIFT);
} else { } else {
reg_hor[c] = 0; reg_hor[c] = 0;
reg_ver[c] = 0; reg_ver[c] = 0;