android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: i2c: max9286: Rework comments in .bound()

Browse Source 
Rephrase a comment in .bound() callback to make it clear we register
a subdev notifier and remove a redundant comment about disabling i2c
auto-ack.

No functional changes intended.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Jacopo Mondi 2021-06-16 14:46:06 +02:00 committed by Mauro Carvalho Chehab
parent 731c24ffa2
commit 4ff5278dce
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/media/i2c/max9286.c
View File

@ -556,9 +556,9 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier,
subdev->name, src_pad, index);
/*
* We can only register v4l2_async_notifiers, which do not provide a
* means to register a complete callback. bound_sources allows us to
* identify when all remote serializers have completed their probe.
* As we register a subdev notifiers we won't get a .complete() callback
* here, so we have to use bound_sources to identify when all remote
* serializers have probed.
*/
if (priv->bound_sources != priv->source_mask)
return 0;
@ -575,11 +575,6 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier,
*/
max9286_reverse_channel_setup(priv, MAX9286_REV_AMP_HIGH);
max9286_check_config_link(priv, priv->source_mask);
/*
* Re-configure I2C with local acknowledge disabled after cameras have
* probed.
*/
max9286_configure_i2c(priv, false);
return max9286_set_pixelrate(priv);