android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "proc: allow pid_revalidate() during LOOKUP_RCU"

Browse Source 
This reverts commit da4d6b9cf8.

Appears to cause stale dcache entries for inodes in /proc/$pid
filesystem resulting in ESRCH failures on access to files
under /proc/self

Bug: 305682813
Bug: 306055483
Signed-off-by: Todd Kjos <tkjos@google.com>
Change-Id: I004338c043d7e777fdfef343e45ccb20ff4d503b
This commit is contained in:
Todd Kjos 2023-11-06 18:12:08 +00:00
parent 230d34da33
commit 43a07d84da
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
fs/proc/base.c
View File

@ -2022,21 +2022,19 @@ static int pid_revalidate(struct dentry *dentry, unsigned int flags)
{ {
struct inode *inode; struct inode *inode;
struct task_struct *task; struct task_struct *task;
int ret = 0;
rcu_read_lock(); if (flags & LOOKUP_RCU)
inode = d_inode_rcu(dentry); return -ECHILD;
if (!inode)
goto out; inode = d_inode(dentry);
task = pid_task(proc_pid(inode), PIDTYPE_PID); task = get_proc_task(inode);
if (task) { if (task) {
pid_update_inode(task, inode); pid_update_inode(task, inode);
ret = 1; put_task_struct(task);
return 1;
} }
out: return 0;
rcu_read_unlock();
return ret;
} }
static inline bool proc_inode_is_dead(struct inode *inode) static inline bool proc_inode_is_dead(struct inode *inode)