android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i2c-designware: i2c_dw_read: Remove redundant target address checker

Browse Source 
I2c_dw_xfer_msg() also has the same target address inconsistency check,
and furthermore it checks across all i2c_msg messages, while
i2c_dw_read() walks through i2c_msg messages only with_ I2C_M_RD flag.
That is, target address check in i2c_dw_read() is redundant and useless.

Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
This commit is contained in:
Shinya Kuribayashi 2009-11-06 21:50:22 +09:00 committed by Ben Dooks
parent 52d7e430cf
commit 41c4e35037
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/i2c/busses/i2c-designware.c
View File

@ -419,7 +419,6 @@ static void
i2c_dw_read(struct dw_i2c_dev *dev) i2c_dw_read(struct dw_i2c_dev *dev)
{ {
struct i2c_msg *msgs = dev->msgs; struct i2c_msg *msgs = dev->msgs;
u32 addr = msgs[dev->msg_read_idx].addr;
int rx_valid; int rx_valid;
for (; dev->msg_read_idx < dev->msgs_num; dev->msg_read_idx++) { for (; dev->msg_read_idx < dev->msgs_num; dev->msg_read_idx++) {
@ -429,10 +428,6 @@ i2c_dw_read(struct dw_i2c_dev *dev)
if (!(msgs[dev->msg_read_idx].flags & I2C_M_RD)) if (!(msgs[dev->msg_read_idx].flags & I2C_M_RD))
continue; continue;
/* different i2c client, reprogram the i2c adapter */
if (msgs[dev->msg_read_idx].addr != addr)
return;
if (!(dev->status & STATUS_READ_IN_PROGRESS)) { if (!(dev->status & STATUS_READ_IN_PROGRESS)) {
len = msgs[dev->msg_read_idx].len; len = msgs[dev->msg_read_idx].len;
buf = msgs[dev->msg_read_idx].buf; buf = msgs[dev->msg_read_idx].buf;