android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/drm_file: fix use of uninitialized variable

Browse Source 
[ Upstream commit 1d3062fad9c7313fff9970a88e0538a24480ffb8 ]

smatch reports:

drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized symbol 'supported_status'.

'supported_status' is only set in one code path. I'm not familiar with
the code to say if that path will always be ran in real life, but
whether that is the case or not, I think it is good to initialize
'supported_status' to 0 to silence the warning (and possibly fix a bug).

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231103-uninit-fixes-v2-1-c22b2444f5f5@ideasonboard.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Tomi Valkeinen 2023-11-03 15:14:03 +02:00 committed by Greg Kroah-Hartman
parent 48ad42cd95
commit 406f8d5bad
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/drm_file.c
View File

@ -406,7 +406,7 @@ int drm_open(struct inode *inode, struct file *filp)
{ {
struct drm_device *dev; struct drm_device *dev;
struct drm_minor *minor; struct drm_minor *minor;
int retcode; int retcode = 0;
int need_setup = 0; int need_setup = 0;
minor = drm_minor_acquire(iminor(inode)); minor = drm_minor_acquire(iminor(inode));