android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proc: fix return value of proc_reg_open() in "too late" case

Browse Source 
If ->open() wasn't called, returning 0 is misleading and, theoretically,
oopsable:
1) remove_proc_entry clears ->proc_fops, drops lock,
2) ->open "succeeds",
3) ->release oopses, because it assumes ->open was called (single_release()).

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
This commit is contained in:
Alexey Dobriyan 2008-10-03 00:18:52 +04:00
parent 3fa8749e58
commit 300b994b74
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/proc/inode.c
View File

@ -342,7 +342,7 @@ static int proc_reg_open(struct inode *inode, struct file *file)
if (!pde->proc_fops) { if (!pde->proc_fops) {
spin_unlock(&pde->pde_unload_lock); spin_unlock(&pde->pde_unload_lock);
kfree(pdeo); kfree(pdeo);
return rv; return -EINVAL;
} }
pde->pde_users++; pde->pde_users++;
open = pde->proc_fops->open; open = pde->proc_fops->open;