android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

parisc: led: Use for_each_netdev_rcu()

Browse Source 
Use for_each_netdev_rcu() and dont lock dev_base_lock anymore

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2009-11-09 18:07:28 +00:00 committed by David S. Miller
parent 292f4f3ce4
commit 246c65add0
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/parisc/led.c
View File

@ -352,11 +352,9 @@ static __inline__ int led_get_net_activity(void)
rx_total = tx_total = 0; rx_total = tx_total = 0;
/* we are running as a workqueue task, so locking dev_base /* we are running as a workqueue task, so we can use an RCU lookup */
* for reading should be OK */
read_lock(&dev_base_lock);
rcu_read_lock(); rcu_read_lock();
for_each_netdev(&init_net, dev) { for_each_netdev_rcu(&init_net, dev) {
const struct net_device_stats *stats; const struct net_device_stats *stats;
struct in_device *in_dev = __in_dev_get_rcu(dev); struct in_device *in_dev = __in_dev_get_rcu(dev);
if (!in_dev || !in_dev->ifa_list) if (!in_dev || !in_dev->ifa_list)
@ -368,7 +366,6 @@ static __inline__ int led_get_net_activity(void)
tx_total += stats->tx_packets; tx_total += stats->tx_packets;
} }
rcu_read_unlock(); rcu_read_unlock();
read_unlock(&dev_base_lock);
retval = 0; retval = 0;