android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: stk1160: Fixed high volume of stk1160_dbg messages

Browse Source 
[ Upstream commit b3695e86d25aafbe175dd51f6aaf6f68d341d590 ]

The function stk1160_dbg gets called too many times, which causes
the output to get flooded with messages. Since stk1160_dbg uses
printk, it is now replaced with printk_ratelimited.

Suggested-by: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ghanshyam Agrawal 2023-11-25 14:32:36 +05:30 committed by Greg Kroah-Hartman
parent 25eaa9f999
commit 1ef8beb4bf
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/media/usb/stk1160/stk1160-video.c
View File

@ -107,8 +107,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
/* /*
* TODO: These stk1160_dbg are very spammy! * TODO: These stk1160_dbg are very spammy!
* We should 1) check why we are getting them * We should check why we are getting them.
* and 2) add ratelimit.
* *
* UPDATE: One of the reasons (the only one?) for getting these * UPDATE: One of the reasons (the only one?) for getting these
* is incorrect standard (mismatch between expected and configured). * is incorrect standard (mismatch between expected and configured).
@ -151,7 +150,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
/* Let the bug hunt begin! sanity checks! */ /* Let the bug hunt begin! sanity checks! */
if (lencopy < 0) { if (lencopy < 0) {
stk1160_dbg("copy skipped: negative lencopy\n"); printk_ratelimited(KERN_DEBUG "copy skipped: negative lencopy\n");
return; return;
} }