android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

thermal: int3400_thermal: fix error handling in int3400_thermal_probe()

Browse Source 
There are resources that are not dealocated on failure path
in int3400_thermal_probe().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
This commit is contained in:
Alexey Khoroshilov 2017-12-30 01:05:21 +03:00 committed by Zhang Rui
parent 261ac1d2d9
commit 0be86969ae
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/thermal/int340x_thermal/int3400_thermal.c
View File

@ -319,17 +319,21 @@ static int int3400_thermal_probe(struct platform_device *pdev)
result = sysfs_create_group(&pdev->dev.kobj, &uuid_attribute_group); result = sysfs_create_group(&pdev->dev.kobj, &uuid_attribute_group);
if (result) if (result)
goto free_zone; goto free_rel_misc;
result = acpi_install_notify_handler( result = acpi_install_notify_handler(
priv->adev->handle, ACPI_DEVICE_NOTIFY, int3400_notify, priv->adev->handle, ACPI_DEVICE_NOTIFY, int3400_notify,
(void *)priv); (void *)priv);
if (result) if (result)
goto free_zone; goto free_sysfs;
return 0; return 0;
free_zone: free_sysfs:
sysfs_remove_group(&pdev->dev.kobj, &uuid_attribute_group);
free_rel_misc:
if (!priv->rel_misc_dev_res)
acpi_thermal_rel_misc_device_remove(priv->adev->handle);
thermal_zone_device_unregister(priv->thermal); thermal_zone_device_unregister(priv->thermal);
free_art_trt: free_art_trt:
kfree(priv->trts); kfree(priv->trts);