android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: sony: remove duplicate NULL check before calling usb_free_urb()

Browse Source 
[ Upstream commit b328dd02e19cb9d3b35de4322f5363516a20ac8c ]

usb_free_urb() does the NULL check itself, so there is no need to duplicate
it prior to calling.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: e1cd4004cde7c9 ("HID: sony: Fix a potential memory leak in sony_probe()")
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jiri Kosina 2023-10-04 21:10:41 +02:00 committed by Greg Kroah-Hartman
parent 40d609b6ad
commit 07c6338acb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/hid/hid-sony.c
View File

@ -3074,8 +3074,7 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id)
return ret;
err:
if (sc->ghl_urb)
usb_free_urb(sc->ghl_urb);
usb_free_urb(sc->ghl_urb);
hid_hw_stop(hdev);
return ret;