android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: sunxi: drop lock on error path

Browse Source 
I forgot to drop the lock for the return inside the loop
protected by the spinlock in the pin config routine when
merging in -rc7 in commit 6ad30ce046

Reported-by: Sherman Yin <syin@broadcom.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Linus Walleij 2013-08-29 19:17:13 +02:00
parent acf564a8f3
commit 07b7eb9279
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/pinctrl-sunxi.c
View File

@ -291,8 +291,10 @@ static int sunxi_pconf_group_set(struct pinctrl_dev *pctldev,
switch (pinconf_to_config_param(configs[i])) { switch (pinconf_to_config_param(configs[i])) {
case PIN_CONFIG_DRIVE_STRENGTH: case PIN_CONFIG_DRIVE_STRENGTH:
strength = pinconf_to_config_argument(configs[i]); strength = pinconf_to_config_argument(configs[i]);
if (strength > 40) if (strength > 40) {
spin_unlock_irqrestore(&pctl->lock, flags);
return -EINVAL; return -EINVAL;
}
/* /*
* We convert from mA to what the register expects: * We convert from mA to what the register expects:
* 0: 10mA * 0: 10mA