android/android_kernel_samsung_sm8650
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ima_write_policy(): don't open-code memdup_user_nul()

Browse Source 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2017-05-13 18:15:25 -04:00
parent 0b884d25f5
commit 02412e9b4e
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
security/integrity/ima/ima_fs.c
View File

@ -323,16 +323,11 @@ static ssize_t ima_write_policy(struct file *file, const char __user *buf,
if (*ppos != 0) if (*ppos != 0)
goto out; goto out;
result = -ENOMEM; data = memdup_user_nul(buf, datalen);
data = kmalloc(datalen + 1, GFP_KERNEL); if (IS_ERR(data)) {
if (!data) result = PTR_ERR(data);
goto out; goto out;
}
*(data + datalen) = '\0';
result = -EFAULT;
if (copy_from_user(data, buf, datalen))
goto out_free;
result = mutex_lock_interruptible(&ima_write_mutex); result = mutex_lock_interruptible(&ima_write_mutex);
if (result < 0) if (result < 0)