android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
ee5e7632e9
android_kernel_asus_sm8350/drivers/mmc/core
History
Geert Uytterhoeven a9c9ffcd21 mmc: core: Cancel delayed work before releasing host 
commit 1036f69e251380573e256568cf814506e3fb9988 upstream.

On RZ/Five SMARC EVK, where probing of SDHI is deferred due to probe
deferral of the vqmmc-supply regulator:

    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 0 at kernel/time/timer.c:1738 __run_timers.part.0+0x1d0/0x1e8
    Modules linked in:
    CPU: 0 PID: 0 Comm: swapper Not tainted 6.7.0-rc4 #101
    Hardware name: Renesas SMARC EVK based on r9a07g043f01 (DT)
    epc : __run_timers.part.0+0x1d0/0x1e8
     ra : __run_timers.part.0+0x134/0x1e8
    epc : ffffffff800771a4 ra : ffffffff80077108 sp : ffffffc800003e60
     gp : ffffffff814f5028 tp : ffffffff8140c5c0 t0 : ffffffc800000000
     t1 : 0000000000000001 t2 : ffffffff81201300 s0 : ffffffc800003f20
     s1 : ffffffd8023bc4a0 a0 : 00000000fffee6b0 a1 : 0004010000400000
     a2 : ffffffffc0000016 a3 : ffffffff81488640 a4 : ffffffc800003e60
     a5 : 0000000000000000 a6 : 0000000004000000 a7 : ffffffc800003e68
     s2 : 0000000000000122 s3 : 0000000000200000 s4 : 0000000000000000
     s5 : ffffffffffffffff s6 : ffffffff81488678 s7 : ffffffff814886c0
     s8 : ffffffff814f49c0 s9 : ffffffff81488640 s10: 0000000000000000
     s11: ffffffc800003e60 t3 : 0000000000000240 t4 : 0000000000000a52
     t5 : ffffffd8024ae018 t6 : ffffffd8024ae038
    status: 0000000200000100 badaddr: 0000000000000000 cause: 0000000000000003
    [<ffffffff800771a4>] __run_timers.part.0+0x1d0/0x1e8
    [<ffffffff800771e0>] run_timer_softirq+0x24/0x4a
    [<ffffffff80809092>] __do_softirq+0xc6/0x1fa
    [<ffffffff80028e4c>] irq_exit_rcu+0x66/0x84
    [<ffffffff80800f7a>] handle_riscv_irq+0x40/0x4e
    [<ffffffff80808f48>] call_on_irq_stack+0x1c/0x28
    ---[ end trace 0000000000000000 ]---

What happens?

    renesas_sdhi_probe()
    {
    	tmio_mmc_host_alloc()
	    mmc_alloc_host()
		INIT_DELAYED_WORK(&host->detect, mmc_rescan);

	devm_request_irq(tmio_mmc_irq);

	/*
	 * After this, the interrupt handler may be invoked at any time
	 *
	 *  tmio_mmc_irq()
	 *  {
	 *	__tmio_mmc_card_detect_irq()
	 *	    mmc_detect_change()
	 *		_mmc_detect_change()
	 *		    mmc_schedule_delayed_work(&host->detect, delay);
	 *  }
	 */

	tmio_mmc_host_probe()
	    tmio_mmc_init_ocr()
		-EPROBE_DEFER

	tmio_mmc_host_free()
	    mmc_free_host()
    }

When expire_timers() runs later, it warns because the MMC host structure
containing the delayed work was freed, and now contains an invalid work
function pointer.

Fix this by cancelling any pending delayed work before releasing the
MMC host structure.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/205dc4c91b47e31b64392fe2498c7a449e717b4b.1701689330.git.geert+renesas@glider.be
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-01-15 18:25:28 +01:00
..
block.c mmc: rpmb: fixes pause retune on all RPMB partitions. 2024-01-15 18:25:28 +01:00
block.h
bus.c mmc: cqhci: Fix random crash when remove mmc module/card 2021-03-17 17:03:48 +01:00
bus.h
card.h
core.c mmc: block: Be sure to wait while busy in CQE error recovery 2023-12-20 15:41:25 +01:00
core.h mmc: core: Disable card detect during shutdown 2021-12-29 12:23:37 +01:00
debugfs.c
host.c mmc: core: Cancel delayed work before releasing host 2024-01-15 18:25:28 +01:00
host.h
Kconfig
Makefile
mmc_ops.c mmc: block: Be sure to wait while busy in CQE error recovery 2023-12-20 15:41:25 +01:00
mmc_ops.h mmc: block: Be sure to wait while busy in CQE error recovery 2023-12-20 15:41:25 +01:00
mmc_test.c mmc: mmc_test: Fix removal of debugfs file 2022-12-08 11:23:04 +01:00
mmc.c Revert "mmc: core: Capture correct oemid-bits for eMMC cards" 2023-11-20 10:30:16 +01:00
pwrseq_emmc.c
pwrseq_sd8787.c
pwrseq_simple.c
pwrseq.c
pwrseq.h
queue.c mmc: core: don't initialize block size from ext_csd if not present 2021-01-27 11:47:41 +01:00
queue.h
quirks.h mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M 2023-07-27 08:37:25 +02:00
regulator.c mmc: core: add helpers mmc_regulator_enable/disable_vqmmc 2023-12-13 18:18:15 +01:00
sd_ops.c
sd_ops.h
sd.c mmc: core: Terminate infinite loop in SD-UHS voltage switch 2022-10-15 07:54:38 +02:00
sd.h
sdio_bus.c mmc: sdio: fix possible resource leaks in some error paths 2023-02-22 12:50:38 +01:00
sdio_bus.h
sdio_cis.c mmc: sdio: fix possible resource leaks in some error paths 2023-02-22 12:50:38 +01:00
sdio_cis.h
sdio_io.c
sdio_irq.c
sdio_ops.c mmc: sdio: Use mmc_pre_req() / mmc_post_req() 2020-09-17 13:47:53 +02:00
sdio_ops.h
sdio_uart.c
sdio.c mmc: core: sdio: hold retuning if sdio in 1-bit mode 2023-10-25 11:53:24 +02:00
slot-gpio.c
slot-gpio.h