Eric Dumazet 0fcfaa8ed9 af_unix: fix races in sk_peer_pid and sk_peer_cred accesses ... [ Upstream commit 35306eb23814444bd4021f8a1c3047d3cb0c8b2b ] Jann Horn reported that SO_PEERCRED and SO_PEERGROUPS implementations are racy, as af_unix can concurrently change sk_peer_pid and sk_peer_cred. In order to fix this issue, this patch adds a new spinlock that needs to be used whenever these fields are read or written. Jann also pointed out that l2cap_sock_get_peer_pid_cb() is currently reading sk->sk_peer_pid which makes no sense, as this field is only possibly set by AF_UNIX sockets. We will have to clean this in a separate patch. This could be done by reverting b48596d1dc25 "Bluetooth: L2CAP: Add get_peer_pid callback" or implementing what was truly expected. Fixes: 109f6e39fa ("af_unix: Allow SO_PEERCRED to work across namespaces.") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Jann Horn <jannh@google.com> Cc: Eric W. Biederman <ebiederm@xmission.com> Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Cc: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-10-06 15:42:35 +02:00
..
bpf_sk_storage.c	bpf: Improve bucket_log calculation logic	2020-02-14 16:34:10 -05:00
datagram.c	udp: fix skb_copy_and_csum_datagram with odd segment sizes	2021-02-17 10:35:19 +01:00
datagram.h	net/core: Allow the compiler to verify declaration and definition consistency	2019-03-27 13:49:44 -07:00
dev_addr_lists.c	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
dev_ioctl.c	net: fix dev_ifsioc_locked() race condition	2021-03-07 12:20:43 +01:00
dev.c	net: Treat __napi_schedule_irqoff() as __napi_schedule() on PREEMPT_RT	2021-07-19 08:53:08 +02:00
devlink.c	devlink: Hold rtnl lock while reading netdev attributes	2020-12-08 10:40:23 +01:00
drop_monitor.c	drop_monitor: work around gcc-10 stringop-overflow warning	2020-05-20 08:20:06 +02:00
dst_cache.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
dst.c	net: print proper warning on dst underflow	2019-09-26 09:05:56 +02:00
ethtool.c	net: ethtool: clear heap allocations for ethtool function	2021-06-30 08:47:47 -04:00
failover.c	failover: allow name change on IFF_UP slave interfaces	2019-04-10 22:12:26 -07:00
fib_notifier.c	net: fib_notifier: move fib_notifier_ops from struct net into per-net struct	2019-09-07 17:28:22 +02:00
fib_rules.c	fib: Return the correct errno code	2021-06-18 09:59:00 +02:00
filter.c	bpf: Do not change gso_size during bpf_skb_change_proto()	2021-07-14 16:53:32 +02:00
flow_dissector.c	flow_dissector: Fix out-of-bounds warnings	2021-09-22 12:26:29 +02:00
flow_offload.c	net: core: rename indirect block ingress cb function	2019-12-18 16:08:47 +01:00
gen_estimator.c	net_sched: gen_estimator: support large ewma log	2021-02-07 15:35:47 +01:00
gen_stats.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
gro_cells.c	gro_cells: make sure device is up in gro_cells_receive()	2019-03-10 11:07:14 -07:00
hwbm.c	net: hwbm: Make the hwbm_pool lock a mutex	2019-06-09 19:40:10 -07:00
link_watch.c	net: linkwatch: fix failure to restore device state across suspend/resume	2021-08-18 08:57:00 +02:00
lwt_bpf.c	lwt: Disable BH too in run_lwt_bpf()	2020-12-30 11:51:30 +01:00
lwtunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Makefile	bpf: Introduce bpf sk local storage	2019-04-27 09:07:04 -07:00
neighbour.c	neighbour: allow NUD_NOARP entries to be forced GCed	2021-06-10 13:37:16 +02:00
net_namespace.c	netns: protect netns ID lookups with RCU	2021-09-15 09:47:31 +02:00
net-procfs.c	treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively	2019-04-09 14:19:06 +02:00
net-sysfs.c	net-sysfs: take the rtnl lock when accessing xps_rxqs_map and num_tc	2021-01-12 20:16:13 +01:00
net-sysfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
net-traces.c	page_pool: add tracepoints for page_pool with details need by XDP	2019-06-19 11:23:13 -04:00
netclassid_cgroup.c	cgroup, netclassid: remove double cond_resched	2020-05-10 10:31:32 +02:00
netevent.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netpoll.c	net: Have netpoll bring-up DSA management interface	2020-11-24 13:28:57 +01:00
netprio_cgroup.c	netprio_cgroup: Fix unlimited memory leak of v2 cgroups	2020-05-20 08:20:12 +02:00
page_pool.c	mm: fix struct page layout on 32-bit systems	2021-05-19 10:08:31 +02:00
pktgen.c	pktgen: fix misuse of BUG_ON() in pktgen_thread_worker()	2021-03-07 12:20:44 +01:00
ptp_classifier.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
request_sock.c	tcp: add rcu protection around tp->fastopen_rsk	2019-10-13 10:13:08 -07:00
rtnetlink.c	rtnetlink: Return correct error on changing device netns	2021-09-03 10:08:14 +02:00
scm.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
secure_seq.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
skbuff.c	net: Fix zero-copy head len calculation.	2021-08-08 09:04:08 +02:00
skmsg.c	bpf, sockmap: Avoid returning unneeded EAGAIN when redirecting to self	2020-11-24 13:29:19 +01:00
sock_diag.c	sock: make cookie generation global instead of per netns	2019-08-09 13:14:46 -07:00
sock_map.c	bpf: sockmap: Require attach_bpf_fd when detaching a program	2020-08-07 09:34:02 +02:00
sock_reuseport.c	udp: Prevent reuseport_select_sock from reading uninitialized socks	2021-01-23 15:57:56 +01:00
sock.c	af_unix: fix races in sk_peer_pid and sk_peer_cred accesses	2021-10-06 15:42:35 +02:00
stream.c	tcp: make sure EPOLLOUT wont be missed	2019-08-19 13:07:43 -07:00
sysctl_net_core.c	bpf: Check correct cred for CAP_SYSLOG in bpf_dump_raw_ok()	2020-07-16 08:16:45 +02:00
timestamping.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tso.c	net: Use skb accessors in network core	2019-07-22 20:47:56 -07:00
utils.c	net: Fix skb->csum update in inet_proto_csum_replace16().	2020-02-05 21:22:52 +00:00
xdp.c	xdp: obtain the mem_id mutex before trying to remove an entry.	2019-12-18 16:09:10 +01:00