Eric Dumazet
c57b546840
pktgen: fix crash at module unload
commit 7d3d43dab4e9 (net: In unregister_netdevice_notifier unregister
the netdevices.) makes pktgen crashing at module unload.
[ 296.820578] BUG: spinlock bad magic on CPU#6, rmmod/3267
[ 296.820719] lock: ffff880310c38000, .magic: ffff8803, .owner: <none>/-1, .owner_cpu: -1
[ 296.820943] Pid: 3267, comm: rmmod Not tainted 3.4.0-rc5+ #254
[ 296.821079] Call Trace:
[ 296.821211] [<ffffffff8168a715>] spin_dump+0x8a/0x8f
[ 296.821345] [<ffffffff8168a73b>] spin_bug+0x21/0x26
[ 296.821507] [<ffffffff812b4741>] do_raw_spin_lock+0x131/0x140
[ 296.821648] [<ffffffff8169188e>] _raw_spin_lock+0x1e/0x20
[ 296.821786] [<ffffffffa00cc0fd>] __pktgen_NN_threads+0x4d/0x140 [pktgen]
[ 296.821928] [<ffffffffa00ccf8d>] pktgen_device_event+0x10d/0x1e0 [pktgen]
[ 296.822073] [<ffffffff8154ed4f>] unregister_netdevice_notifier+0x7f/0x100
[ 296.822216] [<ffffffffa00d2a0b>] pg_cleanup+0x48/0x73 [pktgen]
[ 296.822357] [<ffffffff8109528e>] sys_delete_module+0x17e/0x2a0
[ 296.822502] [<ffffffff81699652>] system_call_fastpath+0x16/0x1b
Hold the pktgen_thread_lock while splicing pktgen_threads, and test
pktgen_exiting in pktgen_device_event() to make unload faster.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-05-10 23:10:24 -04:00
..
2012-02-26 14:49:57 -06:00
2012-04-02 17:53:39 -07:00
2012-05-10 23:03:34 -04:00
2011-10-31 19:30:30 -04:00
2012-03-28 18:30:03 +01:00
2012-04-19 15:37:48 -04:00
2012-03-11 15:36:34 -07:00
2012-04-27 15:16:43 -04:00
2012-04-24 00:16:24 -04:00
2012-04-13 11:01:44 -04:00
2011-10-17 19:22:46 -04:00
2012-03-22 10:47:52 -05:00
2012-05-10 23:10:24 -04:00
2011-10-31 19:30:30 -04:00
2012-03-03 09:02:52 -07:00
2012-03-28 18:30:03 +01:00
2012-01-19 14:38:51 +11:00
2011-11-29 00:21:36 -05:00
2012-03-28 18:30:03 +01:00
2012-03-28 18:30:03 +01:00
2012-04-26 05:32:55 -04:00
2012-05-10 22:16:32 -04:00
2012-04-22 17:09:35 -04:00
2011-10-31 19:30:30 -04:00
2012-03-28 18:30:03 +01:00
2012-03-22 18:15:32 -07:00
2012-04-13 11:01:44 -04:00
2012-05-02 21:04:33 -04:00
2012-03-28 18:30:03 +01:00
2012-01-24 15:33:19 -05:00
2012-04-30 14:40:05 -04:00
2012-04-30 10:40:36 +02:00
2012-03-22 19:29:57 -04:00
2012-04-06 04:21:06 -04:00
2012-03-28 18:30:03 +01:00
2012-04-11 15:09:33 -04:00
2012-05-07 17:23:10 -07:00
2012-03-28 18:30:03 +01:00
2012-04-13 11:01:43 -04:00
2012-03-22 19:29:58 -04:00
2012-03-11 14:27:37 -04:00
2012-04-02 17:53:39 -07:00
2012-02-14 14:41:55 -05:00
2012-05-01 13:40:48 -04:00
2012-04-04 18:05:02 -04:00
2012-04-30 11:58:51 -04:00
2012-02-29 11:45:35 -05:00
2012-03-23 16:58:38 -07:00
2011-11-07 13:27:30 -05:00
2011-10-31 19:30:30 -04:00
2012-04-13 14:05:35 -04:00
2011-12-16 15:49:52 -05:00
2012-03-22 19:29:58 -04:00
2012-03-29 18:12:23 -07:00
2011-12-03 09:35:17 -08:00
2011-12-03 09:35:17 -08:00
2012-04-05 19:04:27 -04:00
2012-01-24 16:40:30 -08:00