Joao Martins a55eec14a4
iommu/amd: Fix potential @entry null deref ...
[ Upstream commit 14c4acc5ed22c21f9821103be7c48efdf9763584 ]
After commit 26e495f34107 ("iommu/amd: Restore IRTE.RemapEn bit after
programming IRTE"), smatch warns:
drivers/iommu/amd/iommu.c:3870 amd_iommu_deactivate_guest_mode()
warn: variable dereferenced before check 'entry' (see line 3867)
Fix this by moving the @valid assignment to after @entry has been checked
for NULL.
Fixes: 26e495f34107 ("iommu/amd: Restore IRTE.RemapEn bit after programming IRTE")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Link: https://lore.kernel.org/r/20200910171621.12879-1-joao.m.martins@oracle.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-09-23 12:40:42 +02:00
2020-08-19 08:16:05 +02:00
2020-08-11 15:33:35 +02:00
2020-09-09 19:12:34 +02:00
2020-09-17 13:47:45 +02:00
2020-09-23 12:40:34 +02:00
2020-09-17 13:47:53 +02:00
2020-08-19 08:16:16 +02:00
2020-08-19 08:16:00 +02:00
2020-08-19 08:16:27 +02:00
2020-09-23 12:40:39 +02:00
2020-07-22 09:32:51 +02:00
2020-05-02 08:48:44 +02:00
2020-09-17 13:47:49 +02:00
2020-09-09 19:12:21 +02:00
2020-08-21 13:05:32 +02:00
2020-05-27 17:46:48 +02:00
2020-09-03 11:26:50 +02:00
2020-09-17 13:47:46 +02:00
2020-07-29 10:18:29 +02:00
2020-09-03 11:26:53 +02:00
2020-06-24 17:50:36 +02:00
2020-08-26 10:41:07 +02:00
2020-07-29 10:18:31 +02:00
2020-06-22 09:31:20 +02:00
2020-07-29 10:18:26 +02:00
2020-09-23 12:40:42 +02:00
2020-09-17 13:47:48 +02:00
2020-09-23 12:40:40 +02:00
2020-09-09 19:12:20 +02:00
2020-08-19 08:16:14 +02:00
2020-09-23 12:40:38 +02:00
2020-02-24 08:36:53 +01:00
2020-09-17 13:47:51 +02:00
2020-09-23 12:40:33 +02:00
2020-08-26 10:40:55 +02:00
2020-09-23 12:40:42 +02:00
2020-05-27 17:46:47 +02:00
2020-09-03 11:27:06 +02:00
2020-08-19 08:16:11 +02:00
2020-08-19 08:16:15 +02:00
2020-06-24 17:50:36 +02:00
2020-09-09 19:12:36 +02:00
2020-09-09 19:12:34 +02:00
2020-01-17 19:48:59 +01:00
2020-07-16 08:16:36 +02:00
2020-09-03 11:26:43 +02:00
2020-09-09 19:12:21 +02:00
2020-09-17 13:47:53 +02:00
2020-08-21 13:05:30 +02:00
2020-09-23 12:40:34 +02:00
2020-09-17 13:47:45 +02:00
2020-06-24 17:50:41 +02:00
2020-08-21 13:05:35 +02:00
2020-09-23 12:40:37 +02:00
2020-06-10 20:24:57 +02:00
2020-07-22 09:32:55 +02:00
2020-08-26 10:40:53 +02:00
2020-08-19 08:16:26 +02:00
2020-09-03 11:26:53 +02:00
2020-07-29 10:18:40 +02:00
2020-09-17 13:47:55 +02:00
2020-08-21 13:05:29 +02:00
2020-08-21 13:05:30 +02:00
2020-08-19 08:16:16 +02:00
2020-01-23 08:22:51 +01:00
2020-08-21 13:05:34 +02:00
2020-09-23 12:40:36 +02:00
2020-09-23 12:40:35 +02:00
2020-08-21 13:05:29 +02:00
2020-02-24 08:36:41 +01:00
2020-08-26 10:40:54 +02:00
2020-09-03 11:26:59 +02:00
2020-09-23 12:40:40 +02:00
2020-07-22 09:33:08 +02:00
2020-08-19 08:15:59 +02:00
2020-09-17 13:47:43 +02:00
2020-09-23 12:40:38 +02:00
2020-02-19 19:53:07 +01:00
2020-09-17 13:47:55 +02:00
2020-09-17 13:47:53 +02:00
2020-02-05 21:22:49 +00:00
2020-09-09 19:12:29 +02:00
2020-02-28 17:22:13 +01:00
2020-09-09 19:12:20 +02:00
2020-07-22 09:33:13 +02:00
2020-09-17 13:47:56 +02:00
2020-09-09 19:12:36 +02:00
2020-08-05 09:59:42 +02:00
2020-09-23 12:40:41 +02:00
2020-07-22 09:33:11 +02:00
2020-08-26 10:40:57 +02:00
2020-02-24 08:36:47 +01:00
2020-02-24 08:36:48 +01:00
2020-06-22 09:31:26 +02:00
2020-08-21 13:05:36 +02:00
2020-09-09 19:12:22 +02:00
a55eec14a4