Andrea Righi
27ac792ca0
PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
...
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:
u64 val = PAGE_ALIGN(size);
always returns a value < 4GB even if size is greater than 4GB.
The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):
#define PAGE_SHIFT 12
#define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK)
The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.
Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.
See also lkml discussion: http://lkml.org/lkml/2008/6/11/237
[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:58 +09:00
2008-05-09 19:04:12 +09:00
2008-04-18 09:50:07 -07:00
2008-02-14 14:22:12 +09:00
2007-09-21 15:55:55 +09:00
2006-10-03 23:01:26 +02:00
2007-05-14 09:18:35 +09:00
2007-09-21 11:57:47 +09:00
2006-10-03 13:16:15 +09:00
2008-02-08 09:22:29 -08:00
2005-04-16 15:20:36 -07:00
2008-01-28 13:18:59 +09:00
2008-01-28 13:18:58 +09:00
2006-12-12 08:42:08 +09:00
2006-12-12 08:42:08 +09:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:19:00 +09:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:58 +09:00
2008-04-26 19:21:16 +02:00
2008-01-28 13:18:52 +09:00
2008-04-18 09:50:01 -07:00
2008-03-14 17:21:09 +09:00
2008-01-28 13:18:38 +09:00
2008-01-07 13:50:18 +09:00
2008-06-02 12:40:14 +09:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:45 +09:00
2007-07-20 13:29:09 +09:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:58 +09:00
2007-05-09 01:35:01 +00:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-03-06 17:23:15 +09:00
2006-12-01 14:52:01 -08:00
2005-04-16 15:20:36 -07:00
2008-01-28 13:19:04 +09:00
2007-09-21 11:57:53 +09:00
2007-05-09 17:36:15 +09:00
2007-05-09 08:58:16 +02:00
2008-01-28 13:19:00 +09:00
2005-07-26 14:35:41 -07:00
2008-02-26 14:28:48 +09:00
2005-04-16 15:20:36 -07:00
2007-07-17 10:23:11 -07:00
2005-09-07 16:57:38 -07:00
2008-01-28 13:18:59 +09:00
2008-01-28 13:19:00 +09:00
2008-03-26 19:09:21 +09:00
2006-01-16 23:15:28 -08:00
2007-06-18 13:58:32 +09:00
2008-04-30 08:29:52 -07:00
2007-09-21 11:57:49 +09:00
2006-04-26 12:56:16 +01:00
2008-01-28 13:19:01 +09:00
2007-09-21 11:57:51 +09:00
2008-02-14 14:22:11 +09:00
2008-07-24 10:47:17 -07:00
2008-05-08 19:52:03 +09:00
2008-04-22 22:16:47 +02:00
2008-04-18 00:46:34 +02:00
2007-09-21 11:57:48 +09:00
2006-01-16 23:15:28 -08:00
2008-02-14 14:22:09 +09:00
2008-05-08 19:51:37 +09:00
2006-01-10 08:01:34 -08:00
2008-02-14 14:22:07 +09:00
2005-04-16 15:20:36 -07:00
2006-10-06 15:31:16 +09:00
2008-02-14 14:22:12 +09:00
2008-01-28 13:18:40 +09:00
2008-01-28 13:18:40 +09:00
2008-01-28 13:18:40 +09:00
2008-01-28 13:19:02 +09:00
2007-10-16 09:42:50 -07:00
2007-05-08 11:15:07 -07:00
2008-05-16 15:09:08 +09:00
2006-04-26 12:56:16 +01:00
2008-04-02 15:28:18 -07:00
2007-05-07 02:11:55 +00:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-01-28 23:21:18 +01:00
2007-09-21 11:57:54 +09:00
2006-09-27 17:45:01 +09:00
2008-01-28 13:19:01 +09:00
2008-04-18 09:50:03 -07:00
2006-02-15 15:32:22 -08:00
2008-01-28 13:18:41 +09:00
2008-02-14 14:22:12 +09:00
2008-05-08 19:51:37 +09:00
2007-02-13 10:54:45 +09:00
2008-05-08 19:51:51 +09:00
2008-01-28 13:18:39 +09:00
2005-04-16 15:20:36 -07:00
2006-01-09 15:59:19 -08:00
2005-04-16 15:20:36 -07:00
2008-07-24 10:47:21 -07:00
2008-01-28 13:19:01 +09:00
2007-07-07 07:28:11 +09:00
2008-01-28 13:18:55 +09:00
2005-04-16 15:20:36 -07:00
2008-02-08 09:22:42 -08:00
2008-04-28 08:58:23 -07:00
2008-04-28 08:58:23 -07:00
2008-01-28 13:19:00 +09:00
2006-09-27 16:20:22 +09:00
2007-05-11 08:29:34 -07:00
2008-01-28 13:19:02 +09:00
2008-01-28 13:19:02 +09:00
2008-03-14 17:21:09 +09:00
2008-03-26 19:02:47 +09:00
2008-03-26 19:02:47 +09:00
2008-04-18 09:50:07 -07:00
2008-01-28 13:18:50 +09:00
2006-12-12 08:42:07 +09:00
2008-05-08 19:51:44 +09:00
2005-04-16 15:20:36 -07:00
2008-01-28 13:18:58 +09:00
2008-02-14 14:22:09 +09:00
2007-06-08 11:56:31 +09:00
2008-01-28 13:19:00 +09:00
2008-01-28 13:19:04 +09:00
2006-12-06 10:45:37 +09:00
2006-09-27 18:09:34 +09:00
2008-04-18 09:50:02 -07:00
2008-04-18 09:50:01 -07:00
2007-10-19 23:10:43 +02:00
2007-05-07 02:11:55 +00:00
2007-05-07 02:11:56 +00:00
2008-01-28 13:18:59 +09:00
2005-04-16 15:20:36 -07:00
2008-04-17 10:42:34 -04:00
2005-04-16 15:20:36 -07:00
2007-02-15 18:20:52 +09:00
2007-10-30 17:32:08 +09:00
2006-10-03 13:19:02 +09:00
2005-04-16 15:20:36 -07:00
2008-04-18 09:50:00 -07:00
2005-04-16 15:20:36 -07:00
2006-10-19 17:31:22 +09:00
2006-09-27 15:29:18 +09:00
2008-01-28 13:18:57 +09:00
2005-04-16 15:20:36 -07:00
2006-07-02 13:58:48 -07:00
2006-09-27 11:16:20 +09:00
2008-06-26 11:22:58 +02:00
2007-09-21 11:57:47 +09:00
2008-01-31 19:27:19 -08:00
2007-04-25 22:24:04 -07:00
2007-06-08 02:43:43 +00:00
2008-01-28 16:24:46 +09:00
2007-09-21 11:57:51 +09:00
2007-09-21 11:57:51 +09:00
2008-01-28 13:18:53 +09:00
2005-04-16 15:20:36 -07:00
2008-01-28 13:18:40 +09:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:40 +09:00
2008-02-14 14:22:09 +09:00
2008-01-28 13:18:59 +09:00
2008-04-18 09:50:01 -07:00
2007-10-19 23:10:43 +02:00
2008-02-14 14:22:07 +09:00
2008-02-14 14:22:07 +09:00
2008-01-28 23:21:18 +01:00
2007-05-09 17:33:24 +09:00
2005-04-16 15:20:36 -07:00
2006-12-06 12:05:02 +09:00
2008-05-08 19:51:37 +09:00
2008-02-14 14:22:11 +09:00
2007-10-19 11:53:34 -07:00
2008-05-08 13:40:17 +09:00
2008-05-02 16:18:40 -07:00
2008-04-18 09:50:02 -07:00
2008-05-08 19:51:37 +09:00
2008-02-14 14:22:09 +09:00
2007-07-26 15:37:57 +09:00
2005-04-16 15:20:36 -07:00
2008-04-29 08:06:27 -07:00
2008-02-14 14:22:08 +09:00
2008-02-14 14:22:08 +09:00
2008-01-28 13:18:45 +09:00
2008-02-07 08:42:30 -08:00
2007-11-07 20:19:30 +09:00
2006-09-27 12:31:01 +09:00
2005-04-16 15:20:36 -07:00