Christian Lamparter
9e81eccf19
cfg80211: double free in __cfg80211_scan_done
This patch fixes a double free corruption in __cfg80211_scan_done:
================================================
BUG kmalloc-512: Object already free
------------------------------------------------
INFO: Allocated in load_elf_binary+0x18b/0x19af age=6
INFO: Freed in load_elf_binary+0x104e/0x19af age=5
INFO: Slab 0xffffea0001bae4c0 objects=14 used=7
INFO: Object 0xffff88007e8a9918 @offset=6424 fp=0xffff88007e8a9488
Bytes b4 0xffff88007e8a9908: 00 00 00 00 00 00 00 00 5a 5a
[...]
Pid: 28705, comm: rmmod Tainted: P C 2.6.31-rc2-wl #1
Call Trace:
[<ffffffff810da9f4>] print_trailer+0x14e/0x16e
[<ffffffff810daa56>] object_err+0x42/0x61
[<ffffffff810dbcd9>] __slab_free+0x2af/0x396
[<ffffffffa0ec9694>] ? wiphy_unregister+0x92/0x142 [cfg80211]
[<ffffffff810dd5e3>] kfree+0x13c/0x17a
[<ffffffffa0ec9694>] ? wiphy_unregister+0x92/0x142 [cfg80211]
[<ffffffffa0ec9694>] wiphy_unregister+0x92/0x142 [cfg80211]
[<ffffffffa0eed163>] ieee80211_unregister_hw+0xc8/0xff [mac80211]
[<ffffffffa0f3fbc8>] p54_unregister_common+0x31/0x66 [p54common]
[...]
FIX kmalloc-512: Object at 0xffff88007e8a9918 not freed
The code path which leads to the *funny* double free:
request = rdev->scan_req;
dev = dev_get_by_index(&init_net, request->ifidx);
/*
* the driver was unloaded recently and
* therefore dev_get_by_index will return NULL!
*/
if (!dev)
goto out;
[...]
rdev->scan_req = NULL; /* not executed... */
[...]
out:
kfree(request);
Signed-off-by: Christian Lamparter <chunkeey@web.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-07-21 12:07:44 -04:00
..
2009-07-02 13:17:01 -07:00
2009-05-25 01:53:53 -07:00
2009-06-10 01:11:22 -07:00
2009-06-18 00:29:12 -07:00
2009-07-09 17:06:57 -07:00
2009-06-23 16:36:25 -07:00
2009-06-18 00:29:12 -07:00
2009-06-26 13:51:32 -07:00
2009-07-15 11:20:38 -07:00
2009-07-20 08:23:36 -07:00
2009-01-04 17:29:21 -08:00
2009-07-09 17:06:57 -07:00
2009-06-26 13:51:27 -07:00
2009-07-05 18:03:35 -07:00
2009-06-17 04:31:25 -07:00
2009-05-25 01:53:53 -07:00
2009-06-29 18:20:28 +04:00
2009-07-20 07:49:08 -07:00
2009-07-20 07:49:08 -07:00
2009-06-18 00:29:12 -07:00
2009-06-23 16:36:25 -07:00
2009-07-09 17:06:57 -07:00
2009-06-18 00:29:12 -07:00
2009-06-18 00:29:12 -07:00
2009-07-21 12:07:40 -04:00
2009-07-16 14:03:40 +02:00
2009-05-21 16:50:24 -07:00
2009-06-18 00:29:12 -07:00
2009-06-18 00:29:12 -07:00
2009-06-18 00:29:12 -07:00
2009-06-25 02:58:16 -07:00
2009-05-18 21:08:20 -07:00
2009-07-21 12:07:38 -04:00
2009-06-18 00:29:12 -07:00
2009-07-09 17:06:57 -07:00
2009-06-18 00:29:12 -07:00
2009-07-06 12:47:08 -07:00
2009-06-26 13:51:34 -07:00
2009-05-21 16:50:23 -07:00
2009-07-09 17:06:57 -07:00
2009-02-26 23:13:36 -08:00
2009-06-11 11:12:48 -07:00
2009-07-21 12:07:44 -04:00
2009-06-18 00:29:12 -07:00
2009-06-29 19:41:46 -07:00
2009-02-15 22:43:35 -08:00
2009-06-09 05:25:32 -07:00
2009-06-09 05:25:32 -07:00
2009-04-06 18:05:43 -07:00
2009-03-16 16:23:30 +01:00