Ye Bin 87fd18016a blk-mq: fix possible memleak when register 'hctx' failed ... [ Upstream commit 4b7a21c57b14fbcd0e1729150189e5933f5088e9 ] There's issue as follows when do fault injection test: unreferenced object 0xffff888132a9f400 (size 512): comm "insmod", pid 308021, jiffies 4324277909 (age 509.733s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 08 f4 a9 32 81 88 ff ff ...........2.... 08 f4 a9 32 81 88 ff ff 00 00 00 00 00 00 00 00 ...2............ backtrace: [<00000000e8952bb4>] kmalloc_node_trace+0x22/0xa0 [<00000000f9980e0f>] blk_mq_alloc_and_init_hctx+0x3f1/0x7e0 [<000000002e719efa>] blk_mq_realloc_hw_ctxs+0x1e6/0x230 [<000000004f1fda40>] blk_mq_init_allocated_queue+0x27e/0x910 [<00000000287123ec>] __blk_mq_alloc_disk+0x67/0xf0 [<00000000a2a34657>] 0xffffffffa2ad310f [<00000000b173f718>] 0xffffffffa2af824a [<0000000095a1dabb>] do_one_initcall+0x87/0x2a0 [<00000000f32fdf93>] do_init_module+0xdf/0x320 [<00000000cbe8541e>] load_module+0x3006/0x3390 [<0000000069ed1bdb>] __do_sys_finit_module+0x113/0x1b0 [<00000000a1a29ae8>] do_syscall_64+0x35/0x80 [<000000009cd878b0>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 Fault injection context as follows: kobject_add blk_mq_register_hctx blk_mq_sysfs_register blk_register_queue device_add_disk null_add_dev.part.0 [null_blk] As 'blk_mq_register_hctx' may already add some objects when failed halfway, but there isn't do fallback, caller don't know which objects add failed. To solve above issue just do fallback when add objects failed halfway in 'blk_mq_register_hctx'. Signed-off-by: Ye Bin <yebin10@huawei.com> Reviewed-by: Ming Lei <ming.lei@redhat.com> Link: https://lore.kernel.org/r/20221117022940.873959-1-yebin@huaweicloud.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-01-18 11:41:38 +01:00
..
partitions	docs: admin-guide: add a series of orphaned documents	2019-07-15 11:03:02 -03:00
badblocks.c	block: switch all files cleared marked as GPLv2 to SPDX tags	2019-04-30 16:11:57 -06:00
bfq-cgroup.c	block, bfq: fix null pointer dereference in bfq_bio_bfqg()	2022-12-08 11:22:57 +01:00
bfq-iosched.c	block, bfq: protect 'bfqd->queued' by 'bfqd->lock'	2022-11-10 17:57:54 +01:00
bfq-iosched.h	bfq: Get rid of __bio_blkcg() usage	2022-06-14 18:11:50 +02:00
bfq-wf2q.c	bfq: fix blkio cgroup leakage v4	2020-09-03 11:26:54 +02:00
bio-integrity.c	block: bio-integrity: Advance seed correctly for larger interval sizes	2022-02-08 18:24:28 +01:00
bio.c	block: fix bio_clone_blkg_association() to associate with proper blkcg_gq	2022-06-14 18:11:50 +02:00
blk-cgroup.c	blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd	2021-09-30 10:09:25 +02:00
blk-core.c	Revert "Revert "block: end bio with BLK_STS_AGAIN in case of non-mq devs and REQ_NOWAIT""	2021-02-07 15:35:47 +01:00
blk-exec.c	block: add SPDX tags to block layer files missing licensing information	2019-04-30 16:12:03 -06:00
blk-flush.c	block: Fix fsync always failed if once failed	2022-03-08 19:07:47 +01:00
blk-integrity.c	block: centralize PI remapping logic to the block layer	2019-09-17 20:03:49 -06:00
blk-ioc.c	block: Fix use-after-free issue accessing struct io_cq	2020-04-17 10:50:04 +02:00
blk-iocost.c	blk-iocost: ioc_pd_free() shouldn't assume irq disabled	2020-09-09 19:12:35 +02:00
blk-iolatency.c	blk-iolatency: Fix inflight count imbalances and IO hangs on offline	2022-06-14 18:11:49 +02:00
blk-lib.c	block: fix 32 bit overflow in __blkdev_issue_discard()	2018-11-14 08:17:18 -07:00
blk-map.c	block: fix memleak when __blk_rq_map_user_iov() is failed	2020-01-12 12:21:43 +01:00
blk-merge.c	block: return ELEVATOR_DISCARD_MERGE if possible	2022-05-25 09:14:38 +02:00
blk-mq-cpumap.c	blk-mq: balance mapping between present CPUs and queues	2019-08-04 21:43:12 -06:00
blk-mq-debugfs-zoned.c	block: Cleanup license notice	2019-01-17 21:21:40 -07:00
blk-mq-debugfs.c	blk-mq: don't create hctx debugfs dir until q->debugfs_dir is created	2022-08-25 11:17:36 +02:00
blk-mq-debugfs.h	blk-mq: no need to check return value of debugfs_create functions	2019-06-13 03:00:30 -06:00
blk-mq-pci.c	block: Fix blk_mq_*_map_queues() kernel-doc headers	2019-05-31 15:12:34 -06:00
blk-mq-rdma.c	block: Fix blk_mq_*_map_queues() kernel-doc headers	2019-05-31 15:12:34 -06:00
blk-mq-sched.c	kyber: fix out of bounds access when preempted	2021-05-19 10:08:30 +02:00
blk-mq-sched.h	block: only call sched requeue_request() for scheduled requests	2020-09-23 12:40:37 +02:00
blk-mq-sysfs.c	blk-mq: fix possible memleak when register 'hctx' failed	2023-01-18 11:41:38 +01:00
blk-mq-tag.c	blk-mq: introduce blk_mq_tagset_wait_completed_request()	2019-08-04 21:41:29 -06:00
blk-mq-tag.h	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
blk-mq-virtio.c	block: Fix blk_mq_*_map_queues() kernel-doc headers	2019-05-31 15:12:34 -06:00
blk-mq.c	block: remove inaccurate requeue check	2021-11-17 09:48:31 +01:00
blk-mq.h	blk-mq: insert passthrough request into hctx->dispatch directly	2020-03-21 08:11:52 +01:00
blk-pm.c	scsi: block: Fix a race in the runtime power management code	2021-01-06 14:48:37 +01:00
blk-pm.h	block: remove the queue_lock indirection	2018-11-15 12:17:28 -07:00
blk-rq-qos.c	rq-qos: fix missed wake-ups in rq_qos_throttle try two	2021-07-19 08:53:16 +02:00
blk-rq-qos.h	block: fix race between adding/removing rq qos and normal IO	2021-07-14 16:53:18 +02:00
blk-settings.c	blk-settings: align max_sectors on "logical_block_size" boundary	2021-03-04 10:26:40 +01:00
blk-softirq.c	block: remove a few unused exports	2018-11-15 12:13:25 -07:00
blk-stat.c	block: add SPDX tags to block layer files missing licensing information	2019-04-30 16:12:03 -06:00
blk-stat.h	block: deactivate blk_stat timer in wbt_disable_default()	2018-12-12 06:47:51 -07:00
blk-sysfs.c	block: don't delete queue kobject before its children	2022-04-15 14:18:05 +02:00
blk-throttle.c	blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()	2021-09-26 14:07:13 +02:00
blk-timeout.c	block: add SPDX tags to block layer files missing licensing information	2019-04-30 16:12:03 -06:00
blk-wbt.c	blk-wbt: make sure throttle is enabled properly	2021-07-14 16:53:25 +02:00
blk-wbt.h	blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()	2021-07-14 16:53:25 +02:00
blk-zoned.c	blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN	2021-09-22 12:26:19 +02:00
blk.h	block: fix memleak of bio integrity data	2020-01-26 10:01:09 +01:00
bounce.c	block: remove the i argument to bio_for_each_segment_all	2019-04-30 09:26:13 -06:00
bsg-lib.c	block: Fix the type of 'sts' in bsg_queue_rq()	2020-01-23 08:22:44 +01:00
bsg.c	scsi: bsg: Remove support for SCSI_IOCTL_SEND_COMMAND	2021-09-22 12:26:23 +02:00
cmdline-parser.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat_ioctl.c	block/compat_ioctl: fix range check in BLKGETSIZE	2022-04-27 13:50:50 +02:00
elevator.c	block: return ELEVATOR_DISCARD_MERGE if possible	2022-05-25 09:14:38 +02:00
genhd.c	block: Suppress uevent for hidden device when removed	2021-03-30 14:35:23 +02:00
ioctl.c	block: add SPDX tags to block layer files missing licensing information	2019-04-30 16:12:03 -06:00
ioprio.c	block: fix ioprio_get(IOPRIO_WHO_PGRP) vs setuid(2)	2021-12-14 14:49:02 +01:00
Kconfig	blkcg: implement blk-iocost	2019-08-28 21:17:12 -06:00
Kconfig.iosched	docs: block: convert to ReST	2019-07-15 09:20:27 -03:00
kyber-iosched.c	kyber: fix out of bounds access when preempted	2021-05-19 10:08:30 +02:00
Makefile	blkcg: implement blk-iocost	2019-08-28 21:17:12 -06:00
mq-deadline.c	block: return ELEVATOR_DISCARD_MERGE if possible	2022-05-25 09:14:38 +02:00
opal_proto.h	block: sed-opal: Removed duplicate OPAL_METHOD_LENGTH definition	2019-08-20 09:34:49 -06:00
partition-generic.c	block: unhash blkdev part inode when the part is deleted	2022-12-19 12:24:16 +01:00
scsi_ioctl.c	block: switch all files cleared marked as GPLv2 to SPDX tags	2019-04-30 16:11:57 -06:00
sed-opal.c	block: sed-opal: kmalloc the cmd/resp buffers	2022-11-25 17:42:14 +01:00
t10-pi.c	block: t10-pi: fix -Wswitch warning	2019-09-23 08:05:19 -06:00