James Smart 858f090696 scsi: lpfc: Fix rpi release when deleting vport
commit 97acd0019d5dadd9c0e111c2083c889bfe548f25 upstream.

A prior use-after-free mailbox fix solved it's problem by null'ing a ndlp
pointer.  However, further testing has shown that this change causes a
later state change to occasionally be skipped, which results in a reference
count never being decremented thus the rpi is never released, which causes
a vport delete to never succeed.

Revise the fix in the prior patch to no longer null the ndlp. Instead the
RELEASE_RPI flag is set which will drive the release of the rpi.

Given the new code was added at a deep indentation level, refactor the code
block using a new routine that avoids the indentation issues.

Fixes: 	9b1640686470 ("scsi: lpfc: Fix use-after-free mailbox cmd completion")
Link: https://lore.kernel.org/r/20190922035906.10977-6-jsmart2021@gmail.com
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-01-09 10:20:01 +01:00
..
2019-07-11 15:14:01 -07:00
2019-10-05 12:53:27 -07:00
2019-07-11 15:14:01 -07:00
2019-10-25 20:11:33 -04:00
2019-09-21 10:50:15 -07:00
2019-09-21 10:50:15 -07:00
2019-09-21 10:50:15 -07:00
2019-07-11 15:14:01 -07:00
2019-07-11 15:17:41 -07:00
2019-10-05 12:53:27 -07:00
2019-08-29 18:31:39 -04:00
2019-03-02 11:39:54 -08:00
2019-07-11 15:17:41 -07:00
2019-07-11 15:17:41 -07:00
2018-12-18 23:19:21 -05:00
2019-07-11 15:17:41 -07:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:58:35 -05:00
2019-07-20 10:04:58 -07:00
2019-07-11 15:14:01 -07:00
2019-10-25 20:11:33 -04:00
2019-06-18 19:46:18 -04:00
2019-07-11 15:17:41 -07:00
2019-07-11 15:17:41 -07:00
2018-12-18 23:19:21 -05:00
2018-11-06 21:31:28 -05:00
2019-10-25 20:11:33 -04:00
2019-07-11 15:14:01 -07:00
2019-07-11 15:17:41 -07:00
2018-12-28 14:48:06 -08:00
2019-05-20 10:56:43 -04:00
2019-08-16 11:33:56 -07:00
2019-08-16 11:33:56 -07:00
2019-11-11 09:14:36 -08:00
2019-07-11 15:14:01 -07:00
2019-07-11 15:14:01 -07:00
2019-11-05 23:17:53 -05:00
2019-11-02 11:15:52 -07:00
2019-08-04 21:41:29 -06:00
2019-07-11 15:14:01 -07:00
2018-12-18 23:19:21 -05:00
2019-05-21 06:16:23 -04:00
2019-07-11 15:14:01 -07:00
2019-07-11 15:17:41 -07:00
2019-07-11 15:14:01 -07:00