android/android_kernel_asus_sm8350
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
android_kernel_asus_sm8350/fs/btrfs
History
Anand Jain 48b3b9d401 btrfs: fix lock dep warning move scratch super outside of chunk_mutex 
Move scratch super outside of the chunk lock to avoid below
lockdep warning. The better place to scratch super is in
the function btrfs_rm_dev_replace_free_srcdev() just before
free_device, which is outside of the chunk lock as well.

To reproduce:
  (fresh boot)
  mkfs.btrfs -f -draid5 -mraid5 /dev/sdc /dev/sdd /dev/sde
  mount /dev/sdc /btrfs
  dd if=/dev/zero of=/btrfs/tf1 bs=4096 count=100
  (get devmgt from https://github.com/asj/devmgt.git)
  devmgt detach /dev/sde
  dd if=/dev/zero of=/btrfs/tf1 bs=4096 count=100
  sync
  btrfs replace start -Brf 3 /dev/sdf /btrfs <--
  devmgt attach host7

======================================================
[ INFO: possible circular locking dependency detected ]
4.6.0-rc2asj+ #1 Not tainted
---------------------------------------------------

btrfs/2174 is trying to acquire lock:
(sb_writers){.+.+.+}, at:
[<ffffffff812449b4>] __sb_start_write+0xb4/0xf0

but task is already holding lock:
(&fs_info->chunk_mutex){+.+.+.}, at:
[<ffffffffa05c5f55>] btrfs_dev_replace_finishing+0x145/0x980 [btrfs]

which lock already depends on the new lock.

Chain exists of:
sb_writers --> &fs_devs->device_list_mutex --> &fs_info->chunk_mutex
Possible unsafe locking scenario:
CPU0				CPU1
----				----
lock(&fs_info->chunk_mutex);
				lock(&fs_devs->device_list_mutex);
				lock(&fs_info->chunk_mutex);
lock(sb_writers);

*** DEADLOCK ***

-> #0 (sb_writers){.+.+.+}:
[<ffffffff810e6415>] __lock_acquire+0x1bc5/0x1ee0
[<ffffffff810e707e>] lock_acquire+0xbe/0x210
[<ffffffff810df49a>] percpu_down_read+0x4a/0xa0
[<ffffffff812449b4>] __sb_start_write+0xb4/0xf0
[<ffffffff81265534>] mnt_want_write+0x24/0x50
[<ffffffff812508a2>] path_openat+0x952/0x1190
[<ffffffff81252451>] do_filp_open+0x91/0x100
[<ffffffff8123f5cc>] file_open_name+0xfc/0x140
[<ffffffff8123f643>] filp_open+0x33/0x60
[<ffffffffa0572bb6>] update_dev_time+0x16/0x40 [btrfs]
[<ffffffffa057f60d>] btrfs_scratch_superblocks+0x5d/0xb0 [btrfs]
[<ffffffffa057f70e>] btrfs_rm_dev_replace_remove_srcdev+0xae/0xd0 [btrfs]
[<ffffffffa05c62c5>] btrfs_dev_replace_finishing+0x4b5/0x980 [btrfs]
[<ffffffffa05c6ae8>] btrfs_dev_replace_start+0x358/0x530 [btrfs]

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2016-05-06 15:22:49 +02:00
..
tests
mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage
2016-04-04 10:41:08 -07:00
acl.c
Merge branch 'for-linus-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
2016-01-18 12:44:40 -08:00
async-thread.c
btrfs: async-thread: Fix a use-after-free error for trace
2016-01-25 16:50:26 -08:00
async-thread.h
btrfs: async_thread: Fix workqueue 'max_active' value when initializing
2015-08-31 11:46:40 -07:00
backref.c
Merge branch 'cleanups-4.6' into for-chris-4.6
2016-02-26 15:38:33 +01:00
backref.h
btrfs: cleanup, remove inode_item_info helper
2015-01-14 19:23:47 +01:00
btrfs_inode.h
btrfs: put delayed item hook into inode
2016-01-07 14:26:58 +01:00
check-integrity.c
mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage
2016-04-04 10:41:08 -07:00
check-integrity.h
…
compression.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
compression.h
btrfs: move btrfs_compression_type to compression.h
2016-03-11 17:12:46 +01:00
ctree.c
btrfs: fallback to vmalloc in btrfs_compare_tree
2016-04-04 16:29:22 +02:00
ctree.h
btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl
2016-04-28 10:40:27 +02:00
delayed-inode.c
btrfs: Print Warning only if ENOSPC_DEBUG is enabled
2016-03-14 14:59:54 +01:00
delayed-inode.h
btrfs: properly set the termination value of ctx->pos in readdir
2016-02-11 07:01:59 -08:00
delayed-ref.c
btrfs: drop null testing before destroy functions
2016-02-18 11:46:03 +01:00
delayed-ref.h
btrfs: better packing of btrfs_delayed_extent_op
2016-01-07 14:26:58 +01:00
dev-replace.c
btrfs: Reset IO error counters before start of device replacing
2016-04-04 16:29:22 +02:00
dev-replace.h
Btrfs: fix lockdep deadlock warning due to dev_replace
2016-02-23 13:10:10 +01:00
dir-item.c
Btrfs: make xattr replace operations atomic
2014-11-20 17:20:07 -08:00
disk-io.c
Merge branch 'PAGE_CACHE_SIZE-removal'
2016-04-04 10:50:24 -07:00
disk-io.h
Merge branch 'misc-cleanups-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5
2016-01-11 06:08:37 -08:00
export.c
BTRFS: support NFSv2 export
2015-10-06 06:55:23 -07:00
export.h
…
extent_io.c
Btrfs: cleanup error handling in extent_write_cached_pages
2016-04-28 10:41:47 +02:00
extent_io.h
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
extent_map.c
btrfs: Fix misspellings in comments.
2016-03-14 15:05:02 +01:00
extent_map.h
btrfs: cleanup, stop casting for extent_map->lookup everywhere
2016-01-15 19:22:28 +01:00
extent-tree.c
Merge branch 'for-linus-4.6' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
2016-04-09 10:41:34 -07:00
file-item.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
file.c
Btrfs: __btrfs_buffered_write: Pass valid file offset when releasing delalloc space
2016-04-28 10:41:47 +02:00
free-space-cache.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
free-space-cache.h
btrfs: constify remaining structs with function pointers
2016-01-07 15:01:14 +01:00
free-space-tree.c
Revert "btrfs: synchronize incompat feature bits with sysfs files"
2016-01-29 08:19:37 -08:00
free-space-tree.h
Btrfs: implement the free space B-tree
2015-12-17 12:16:47 -08:00
hash.c
btrfs: LLVMLinux: Remove VLAIS
2014-10-14 10:51:22 +02:00
hash.h
…
inode-item.c
Btrfs: consolidate btrfs_error() to btrfs_std_error()
2015-09-29 16:30:00 +02:00
inode-map.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
inode-map.h
Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots
2016-01-15 19:25:02 +01:00
inode.c
btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl
2016-04-28 10:40:27 +02:00
ioctl.c
btrfs: use dynamic allocation for root item in create_subvol
2016-05-06 15:22:49 +02:00
Kconfig
rcu: Make SRCU optional by using CONFIG_SRCU
2015-01-06 11:04:29 -08:00
locking.c
btrfs: cleanup, remove stray return statements
2016-01-07 14:30:52 +01:00
locking.h
btrfs: fix lockups from btrfs_clear_path_blocking
2014-11-19 10:34:35 -08:00
lzo.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
Makefile
Btrfs: add free space tree sanity tests
2015-12-17 12:16:47 -08:00
math.h
btrfs: cleanup 64bit/32bit divs, compile time constants
2015-03-03 17:23:57 +01:00
ordered-data.c
btrfs: Fix misspellings in comments.
2016-03-14 15:05:02 +01:00
ordered-data.h
Btrfs: change how we wait for pending ordered extents
2015-10-21 18:51:40 -07:00
orphan.c
btrfs: kill the key type accessor helpers
2014-09-17 13:37:12 -07:00
print-tree.c
btrfs: teach print_leaf about temporary item subtypes
2016-02-11 16:15:43 +01:00
print-tree.h
…
props.c
btrfs: move btrfs_compression_type to compression.h
2016-03-11 17:12:46 +01:00
props.h
…
qgroup.c
btrfs: Add qgroup tracing
2016-04-04 16:29:22 +02:00
qgroup.h
btrfs: qgroup: Check if qgroup reserved space leaked
2015-10-21 18:41:10 -07:00
raid56.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
raid56.h
Btrfs: add RAID 5/6 BTRFS_RBIO_REBUILD_MISSING operation
2015-08-09 07:34:26 -07:00
rcu-string.h
…
reada.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
relocation.c
Merge branch 'for-linus-4.6' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
2016-04-09 10:41:34 -07:00
root-tree.c
Merge branch 'for-linus-4.6' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
2016-03-21 18:12:42 -07:00
scrub.c
btrfs: Fix BUG_ON condition in scrub_setup_recheck_block()
2016-05-06 15:22:49 +02:00
send.c
btrfs: send: use vmalloc only as fallback for clone_sources_tmp
2016-05-06 15:22:49 +02:00
send.h
Btrfs: use linux/sizes.h to represent constants
2016-01-07 14:38:02 +01:00
struct-funcs.c
mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage
2016-04-04 10:41:08 -07:00
super.c
btrfs: avoid overflowing f_bfree
2016-05-06 15:22:49 +02:00
sysfs.c
btrfs: sysfs: protect reading label by lock
2016-05-06 15:22:49 +02:00
sysfs.h
btrfs: sysfs: introduce helper for syncing bits with sysfs files
2016-01-21 18:50:40 +01:00
transaction.c
Merge branch 'cleanups-4.6' into for-chris-4.6
2016-02-26 15:38:33 +01:00
transaction.h
btrfs: preallocate path for snapshot creation at ioctl time
2016-01-07 15:20:55 +01:00
tree-defrag.c
Btrfs: fix locking bugs when defragging leaves
2015-12-18 02:51:32 +00:00
tree-log.c
Btrfs: fix file/data loss caused by fsync after rename and new inode
2016-04-06 17:01:44 -07:00
tree-log.h
Btrfs: fix unreplayable log after snapshot delete + parent dir fsync
2016-03-01 08:23:25 -08:00
ulist.c
btrfs: ulist: Add ulist_del() function.
2015-06-10 09:26:17 -07:00
ulist.h
btrfs: ulist: Add ulist_del() function.
2015-06-10 09:26:17 -07:00
uuid-tree.c
Btrfs: make btrfs_search_forward return with nodes unlocked
2014-09-17 13:38:02 -07:00
volumes.c
btrfs: fix lock dep warning move scratch super outside of chunk_mutex
2016-05-06 15:22:49 +02:00
volumes.h
Btrfs: fix divide error upon chunk's stripe_len
2016-05-06 15:22:49 +02:00
xattr.c
Btrfs: fix listxattrs not listing all xattrs packed in the same item
2016-03-01 08:23:41 -08:00
xattr.h
btrfs: Use xattr handler infrastructure
2015-12-06 21:34:14 -05:00
zlib.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00