Toshiaki Makita b4e09b29c7 bridge: Fix memory leak when deleting bridge with vlan filtering enabled ... We currently don't call br_vlan_flush() when deleting a bridge, which leads to memory leak if br->vlan_info is allocated. Steps to reproduce: while : do brctl addbr br0 bridge vlan add dev br0 vid 10 self brctl delbr br0 done We can observe the cache size of corresponding slab entry (as kmalloc-2048 in SLUB) is increased. kmemleak output: unreferenced object 0xffff8800b68a7000 (size 2048): comm "bridge", pid 2086, jiffies 4295774704 (age 47.656s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 48 9b 36 00 88 ff ff .........H.6.... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff815eb6ae>] kmemleak_alloc+0x4e/0xb0 [<ffffffff8116a1ca>] kmem_cache_alloc_trace+0xca/0x220 [<ffffffffa03eddd6>] br_vlan_add+0x66/0xe0 [bridge] [<ffffffffa03e543c>] br_setlink+0x2dc/0x340 [bridge] [<ffffffff8150e481>] rtnl_bridge_setlink+0x101/0x200 [<ffffffff8150d9d9>] rtnetlink_rcv_msg+0x99/0x260 [<ffffffff81528679>] netlink_rcv_skb+0xa9/0xc0 [<ffffffff8150d938>] rtnetlink_rcv+0x28/0x30 [<ffffffff81527ccd>] netlink_unicast+0xdd/0x190 [<ffffffff8152807f>] netlink_sendmsg+0x2ff/0x740 [<ffffffff814e8368>] sock_sendmsg+0x88/0xc0 [<ffffffff814e8ac8>] ___sys_sendmsg.part.14+0x298/0x2b0 [<ffffffff814e91de>] __sys_sendmsg+0x4e/0x90 [<ffffffff814e922e>] SyS_sendmsg+0xe/0x10 [<ffffffff81601669>] system_call_fastpath+0x16/0x1b [<ffffffffffffffff>] 0xffffffffffffffff Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp> Signed-off-by: David S. Miller <davem@davemloft.net>		2013-11-14 16:16:34 -05:00
..
netfilter	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nftables	2013-11-04 19:48:57 -05:00
br_device.c	bridge: pass correct vlan id to multicast code	2013-10-29 17:40:08 -04:00
br_fdb.c	bridge: Don't use VID 0 and 4095 in vlan filtering	2013-10-18 16:02:52 -04:00
br_forward.c	bridge: Add a flag to control unicast packet flood.	2013-06-11 02:04:32 -07:00
br_if.c	bridge: Fix memory leak when deleting bridge with vlan filtering enabled	2013-11-14 16:16:34 -05:00
br_input.c	bridge: pass correct vlan id to multicast code	2013-10-29 17:40:08 -04:00
br_ioctl.c	net: Allow userns root to control the network bridge code.	2012-11-18 20:33:00 -05:00
br_mdb.c	Revert "bridge: only expire the mdb entry when query is received"	2013-10-22 14:41:02 -04:00
br_multicast.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-11-04 13:48:30 -05:00
br_netfilter.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2013-11-04 19:46:58 -05:00
br_netlink.c	bridge: Don't use VID 0 and 4095 in vlan filtering	2013-10-18 16:02:52 -04:00
br_notify.c	net: convert resend IGMP to notifier event	2013-07-23 16:52:47 -07:00
br_private_stp.h	net: 8021q/bluetooth/bridge/can/ceph: Remove extern from function prototypes	2013-10-19 19:12:11 -04:00
br_private.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-11-04 13:48:30 -05:00
br_stp_bpdu.c	bridge: set priority of STP packets	2013-02-11 14:16:52 -05:00
br_stp_if.c	bridge: Correctly clamp MAX forward_delay when enabling STP	2013-10-17 16:12:15 -04:00
br_stp_timer.c	bridge: fix race with topology change timer	2013-05-03 16:08:58 -04:00
br_stp.c	bridge: Clamp forward_delay when enabling STP	2013-09-12 23:32:14 -04:00
br_sysfs_br.c	bridge: correct the comment for file br_sysfs_br.c	2013-08-07 10:35:06 -07:00
br_sysfs_if.c	bridge: Add a flag to control unicast packet flood.	2013-06-11 02:04:32 -07:00
br_vlan.c	bridge: Call vlan_vid_del for all vids at nbp_vlan_flush	2013-11-14 16:16:34 -05:00
br.c	net:bridge: use IS_ENABLED	2011-12-16 15:49:52 -05:00
Kconfig	bridge: Add vlan filtering infrastructure	2013-02-13 19:41:46 -05:00
Makefile	bridge: Add vlan filtering infrastructure	2013-02-13 19:41:46 -05:00