3484eba91d
Add a flag option to get xattr method that could have a bit flag of XATTR_NOSECURITY passed to it. XATTR_NOSECURITY is generally then set in the __vfs_getxattr path when called by security infrastructure. This handles the case of a union filesystem driver that is being requested by the security layer to report back the xattr data. For the use case where access is to be blocked by the security layer. The path then could be security(dentry) -> __vfs_getxattr(dentry...XATTR_NOSECURITY) -> handler->get(dentry...XATTR_NOSECURITY) -> __vfs_getxattr(lower_dentry...XATTR_NOSECURITY) -> lower_handler->get(lower_dentry...XATTR_NOSECURITY) which would report back through the chain data and success as expected, the logging security layer at the top would have the data to determine the access permissions and report back the target context that was blocked. Without the get handler flag, the path on a union filesystem would be the errant security(dentry) -> __vfs_getxattr(dentry) -> handler->get(dentry) -> vfs_getxattr(lower_dentry) -> nested -> security(lower_dentry, log off) -> lower_handler->get(lower_dentry) which would report back through the chain no data, and -EACCES. For selinux for both cases, this would translate to a correctly determined blocked access. In the first case with this change a correct avc log would be reported, in the second legacy case an incorrect avc log would be reported against an uninitialized u:object_r:unlabeled:s0 context making the logs cosmetically useless for audit2allow. This patch series is inert and is the wide-spread addition of the flags option for xattr functions, and a replacement of __vfs_getxattr with __vfs_getxattr(...XATTR_NOSECURITY). Signed-off-by: Mark Salyzyn <salyzyn@android.com> Reviewed-by: Jan Kara <jack@suse.cz> Acked-by: Jan Kara <jack@suse.cz> Acked-by: Jeff Layton <jlayton@kernel.org> Acked-by: David Sterba <dsterba@suse.com> Acked-by: Darrick J. Wong <darrick.wong@oracle.com> Acked-by: Mike Marshall <hubcap@omnibond.com> Cc: Stephen Smalley <sds@tycho.nsa.gov> Cc: linux-kernel@vger.kernel.org Cc: kernel-team@android.com Cc: linux-security-module@vger.kernel.org (cherry picked from (rejected from archive because of too many recipients)) Signed-off-by: Mark Salyzyn <salyzyn@google.com> Bug: 133515582 Bug: 136124883 Bug: 129319403 Change-Id: Iabbb8771939d5f66667a26bb23ddf4c562c349a1
153 lines
3.0 KiB
C
153 lines
3.0 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* linux/fs/hfs/attr.c
|
|
*
|
|
* (C) 2003 Ardis Technologies <roman@ardistech.com>
|
|
*
|
|
* Export hfs data via xattr
|
|
*/
|
|
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/xattr.h>
|
|
|
|
#include "hfs_fs.h"
|
|
#include "btree.h"
|
|
|
|
enum hfs_xattr_type {
|
|
HFS_TYPE,
|
|
HFS_CREATOR,
|
|
};
|
|
|
|
static int __hfs_setxattr(struct inode *inode, enum hfs_xattr_type type,
|
|
const void *value, size_t size, int flags)
|
|
{
|
|
struct hfs_find_data fd;
|
|
hfs_cat_rec rec;
|
|
struct hfs_cat_file *file;
|
|
int res;
|
|
|
|
if (!S_ISREG(inode->i_mode) || HFS_IS_RSRC(inode))
|
|
return -EOPNOTSUPP;
|
|
|
|
res = hfs_find_init(HFS_SB(inode->i_sb)->cat_tree, &fd);
|
|
if (res)
|
|
return res;
|
|
fd.search_key->cat = HFS_I(inode)->cat_key;
|
|
res = hfs_brec_find(&fd);
|
|
if (res)
|
|
goto out;
|
|
hfs_bnode_read(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
file = &rec.file;
|
|
|
|
switch (type) {
|
|
case HFS_TYPE:
|
|
if (size == 4)
|
|
memcpy(&file->UsrWds.fdType, value, 4);
|
|
else
|
|
res = -ERANGE;
|
|
break;
|
|
|
|
case HFS_CREATOR:
|
|
if (size == 4)
|
|
memcpy(&file->UsrWds.fdCreator, value, 4);
|
|
else
|
|
res = -ERANGE;
|
|
break;
|
|
}
|
|
|
|
if (!res)
|
|
hfs_bnode_write(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
out:
|
|
hfs_find_exit(&fd);
|
|
return res;
|
|
}
|
|
|
|
static ssize_t __hfs_getxattr(struct inode *inode, enum hfs_xattr_type type,
|
|
void *value, size_t size)
|
|
{
|
|
struct hfs_find_data fd;
|
|
hfs_cat_rec rec;
|
|
struct hfs_cat_file *file;
|
|
ssize_t res = 0;
|
|
|
|
if (!S_ISREG(inode->i_mode) || HFS_IS_RSRC(inode))
|
|
return -EOPNOTSUPP;
|
|
|
|
if (size) {
|
|
res = hfs_find_init(HFS_SB(inode->i_sb)->cat_tree, &fd);
|
|
if (res)
|
|
return res;
|
|
fd.search_key->cat = HFS_I(inode)->cat_key;
|
|
res = hfs_brec_find(&fd);
|
|
if (res)
|
|
goto out;
|
|
hfs_bnode_read(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
}
|
|
file = &rec.file;
|
|
|
|
switch (type) {
|
|
case HFS_TYPE:
|
|
if (size >= 4) {
|
|
memcpy(value, &file->UsrWds.fdType, 4);
|
|
res = 4;
|
|
} else
|
|
res = size ? -ERANGE : 4;
|
|
break;
|
|
|
|
case HFS_CREATOR:
|
|
if (size >= 4) {
|
|
memcpy(value, &file->UsrWds.fdCreator, 4);
|
|
res = 4;
|
|
} else
|
|
res = size ? -ERANGE : 4;
|
|
break;
|
|
}
|
|
|
|
out:
|
|
if (size)
|
|
hfs_find_exit(&fd);
|
|
return res;
|
|
}
|
|
|
|
static int hfs_xattr_get(const struct xattr_handler *handler,
|
|
struct dentry *unused, struct inode *inode,
|
|
const char *name, void *value, size_t size, int flags)
|
|
{
|
|
return __hfs_getxattr(inode, handler->flags, value, size);
|
|
}
|
|
|
|
static int hfs_xattr_set(const struct xattr_handler *handler,
|
|
struct dentry *unused, struct inode *inode,
|
|
const char *name, const void *value, size_t size,
|
|
int flags)
|
|
{
|
|
if (!value)
|
|
return -EOPNOTSUPP;
|
|
|
|
return __hfs_setxattr(inode, handler->flags, value, size, flags);
|
|
}
|
|
|
|
static const struct xattr_handler hfs_creator_handler = {
|
|
.name = "hfs.creator",
|
|
.flags = HFS_CREATOR,
|
|
.get = hfs_xattr_get,
|
|
.set = hfs_xattr_set,
|
|
};
|
|
|
|
static const struct xattr_handler hfs_type_handler = {
|
|
.name = "hfs.type",
|
|
.flags = HFS_TYPE,
|
|
.get = hfs_xattr_get,
|
|
.set = hfs_xattr_set,
|
|
};
|
|
|
|
const struct xattr_handler *hfs_xattr_handlers[] = {
|
|
&hfs_creator_handler,
|
|
&hfs_type_handler,
|
|
NULL
|
|
};
|